db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mamta Satoor <msat...@gmail.com>
Subject Re: [PATCH] Updatable Resultset JDBC api (update and delete for forward only updatable resultsets) support for Network Server
Date Sat, 04 Jun 2005 15:47:59 GMT
Hi Satheesh,
 I have a very small patch to address your review comments on Updatable 
Resultset support for Network Server using Derby Net Client.
 svn stat 
M java\client\org\apache\derby\client\am\ResultSet.java
 Please commit it if there are no issues.
 thanks,
Mamta

 On 5/23/05, Satheesh Bandaram <satheesh@sourcery.org> wrote: 
> 
> Some minor comments... Use them if they apply....
> 
> 
>    1. Not sure if resultSetMetaData_.sqlxRdbnam_[baseTableColumn] is 
>    ever set, so no need to check for that. 
>    2. Use sqlxBasename_ instead of sqlxSchema_ when looking for a valid 
>    base table. While both may work, it may be more readable. 
> 
> Satheesh
> 
>

Mime
View raw message