db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Daniel John Debrunner <...@debrunners.com>
Subject Re: [jira] Commented: (DERBY-31) Statement.setQueryTimeout() support.
Date Thu, 23 Jun 2005 22:17:45 GMT
Oyvind.Bakksjo@Sun.COM wrote:

[on comments about re-use of TimerTasks]
 write a comment about this in the code in a subsequent
> patch (for instance when implementing Statement.cancel), unless anybody
> wants me to address this now and submit a new patch.

I think delaying the comment is fine.

I'm planning to commit this change before the end of this week, assuming
all the tests run for me. One thing I do need is confirmation that the
copyright dates are correct in the files you've added. Some of them have
dates of 1997,2004 which seems unlikely, are all the new files meant to
have a copyright date of 2005? I can fix this if it is the case.

I'm assuming that some performance tests will be run before this code
makes it as part of a release, comparing performance to 10.1/10.0 and
the performance impact of enabling query timeout.

I'm also guessing there are other improvements that could be done, such
as tying the lock timeout to the query timeout value.


Two minor comments on the patch

rather than a new error XJ074.S, the existing generic error XJ081.S
(added by Shreyas) could have been used.

EmbeddedStatement now calculates query timeout * 1000 for every
execution, probably minor but might have been better to store the value
as ms in EmbeddedStatement and just divide / 1000 when getQueryTimeout
is called. Seems execute will be called far more often than getQueryTimeout.

Thanks!
Dan.



Mime
View raw message