db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Kathey Marsden <kmarsdende...@sbcglobal.net>
Subject Re: [PATCH] Derby-8 and Derby-366 Both of them about connection holdability in XA environment
Date Mon, 20 Jun 2005 19:32:45 GMT
Mamta Satoor wrote:

> Hi Kathey,
> I am glad the patch resolved Derby-346 as well.
> <>As for your review comment, the reason I am using reflection is that
> the code to handle holdability for both jdk13 and jdk14+ would be in
> just one place, BrokeredConnection.java. An alternative could be to
> let BrokeredConnection30 use direct method calls and in
> BrokeredConnection.java, check if the jdk version is less than jdk4,
> and if so, use reflection to handle holdability. Let me know if seems
> better to replace the reflection code to handle both jdk13 and
> jdk14+ by having direct call in BrokeredConnection30 and reflection in
> BrokeredConnection. 

I would think that the only potential impact would be the performance
impact of  using reflection for the setState/ syncState calls and I
guess that would not be that great  it seems to me they wouldn't be
called that often. So I agree that it is preferable to have the one set
of code to handle both jdk's. I'll commit this afternoon unless anyone
else disagrees.


View raw message