db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From David Van Couvering <David.Vancouver...@sun.com>
Subject Re: request for patch reviews
Date Mon, 20 Jun 2005 17:45:41 GMT
+1 on Derby-371, except that I'm confused about the TOC page 
("cadminapps.html") -- do all of these links go to separate spots on the 
main page ("cadminappsclientdiffs.html") or do the last two go to other 
pages?  If they go to other pages, shouldn't these part of the review?



Jeff Levitt wrote:

> Hi all,
> There are several JIRA issues relating to docs where I
> have created patches, but we don't know if anyone has
> looked at them to approve the changes.  Jean has been
> committing most of the doc-related issues, and she of
> course would like to make sure that these have been
> reviewed before she commits them, as they should.  The
> list below includes those issues with patches I
> created awaiting approval.  
> I think approval can just take the form of a comment
> in the issue, hopefully from the reporter, saying
> everything looks good, no objections to committing,
> etc.  If there are no objections or changes requested
> to the patch, then we can get it committed and reduce
> the backlog of JIRA issues for docs.  If the reporters
> of these issues and/or anyone else could provide this
> kind of approval feedback, it would be appreciated!
> http://issues.apache.org/jira/browse/DERBY-367 -
> http://issues.apache.org/jira/browse/DERBY-370 -
> updatable resultset and network server changes
> http://issues.apache.org/jira/browse/DERBY-115 - NO
> http://issues.apache.org/jira/browse/DERBY-371 - diffs
> between embedded and network client
> http://issues.apache.org/jira/browse/DERBY-275 - doc
> support for BY DEFAULT option 
> Finally, I believe:
> http://issues.apache.org/jira/browse/DERBY-296
> has gotten at least one approval comment with no
> objections, so if a committer can commit it, we'll
> have all the derby error messages in the Reference Manual.

View raw message