db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Satheesh Bandaram <sathe...@Sourcery.Org>
Subject Re: [PATCH] Updatable Resultset JDBC api (update and delete for forward only updatable resultsets) support for Network Server
Date Thu, 09 Jun 2005 15:05:27 GMT
<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
<html>
<head>
  <meta content="text/html;charset=ISO-8859-1" http-equiv="Content-Type">
  <title></title>
</head>
<body bgcolor="#ffffff" text="#000000">
Not sure what happened... Yes, I see those lines too. Looks like only
part of the patch got merged or committed. I have applied this change
now.<br>
<br>
Satheesh<br>
<br>
[bandaram:satheesh] svn diff -r
189762:189763&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;
<br>
<br>
Mamta Satoor wrote:<br>
<blockquote cite="midd9619e4a05060823561aeb4454@mail.gmail.com"
 type="cite">
  <div>Hi Satheesh,</div>
  <div>&nbsp;</div>
  <div>I did sync on couple of my clients and for some reason,
ResultSet.java still shows the following deleted lines(these were
deleted as part of the commit 189486. Do you or anyone else see these
lines in your client?<br>
-&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; if (resultSetMetaData_.sqlxRdbnam_[baseTableColumn]
!= null
&amp;&amp;<br>
-&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;
!resultSetMetaData_.sqlxRdbnam_[baseTableColumn].equals(""))&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;
//
catalog<br>
-&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; {<br>
-&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;
tableName += "\"" +
resultSetMetaData_.sqlxRdbnam_[baseTableColumn] + "\".";
  <br>
-&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; }<br>
&nbsp;</div>
  <div>thanks,</div>
  <div>Mamta<br>
&nbsp;</div>
  <div><span class="gmail_quote">On 6/7/05, <b class="gmail_sendername">Satheesh
Bandaram</b> &lt;<a href="mailto:satheesh@sourcery.org">satheesh@sourcery.org</a>&gt;
wrote:</span>
  <blockquote class="gmail_quote"
 style="border-left: 1px solid rgb(204, 204, 204); margin: 0px 0px 0px 0.8ex; padding-left:
1ex;">Committed.<br>
    <br>
Sending&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; java\client\org\apache\derby\client\am\<span
class="st0"
 id="st" name="st">
ResultSet</span>.java<br>
Transmitting file data .<br>
Committed revision 189486.<br>
[bandaram:satheesh]<br>
    <br>
Satheesh<br>
    <br>
Mamta Satoor wrote:<br>
    <blockquote
 cite="http://midd9619e4a050604084774392791@mail.gmail.com" type="cite">
      <div><span class="e" id="q_1045999c7a1eb667_1">
      <div>Hi Satheesh,</div>
      <div>&nbsp;</div>
      <div>I have a very small patch to address&nbsp;your review&nbsp;comments
on
Updatable Resultset support for Network Server using Derby Net Client.</div>
      <div>&nbsp;</div>
      <div>svn stat </div>
      <div>M&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; java\client\org\apache\derby\client\am\ResultSet.java</div>
      <div>&nbsp;</div>
      <div>Please commit it if there are no issues.</div>
      <div>&nbsp;</div>
      <div>thanks,</div>
      <div>Mamta<br>
      <br>
&nbsp;</div>
      <div><span class="gmail_quote">On 5/23/05, <b
 class="gmail_sendername">Satheesh Bandaram</b> &lt;<a
 onclick="return top.js.OpenExtLink(window,event,this)"
 href="mailto:satheesh@sourcery.org" target="_blank">satheesh@sourcery.org
      </a>&gt; wrote:</span>
      <blockquote class="gmail_quote"
 style="border-left: 1px solid rgb(204, 204, 204); margin: 0px 0px 0px 0.8ex; padding-left:
1ex;">Some
minor comments... Use them if they apply....<br>
        <br>
        <ol>
          <li>Not sure if
resultSetMetaData_.sqlxRdbnam_[baseTableColumn] is ever set, so no need
to check for that. </li>
          <li>Use sqlxBasename_ instead of sqlxSchema_ when looking for
a valid base table. While both may work, it may be more readable. </li>
        </ol>
Satheesh<br>
        <br>
        <blockquote
 cite="http://midd9619e4a05052102445330a565@mail.gmail.com" type="cite">
          <div>&nbsp;</div>
        </blockquote>
      </blockquote>
      </div>
      </span></div>
      <pre><hr size="4" width="90%">
Index: java/client/org/apache/derby/client/am/<span class="st0" id="st"
 name="st">ResultSet</span>.java ===================================================================
--- java/client/org/apache/derby/client/am/<span class="st0" id="st"
 name="st">ResultSet</span>.java (revision 179793) +++ java/client/org/apache/derby/client/am/<span
 class="st0" id="st" name="st">ResultSet</span>.java (working copy) @@ -3134,7 +3134,7
@@ int baseTableColumn = 0; int totalColumns = resultSetMetaData_.getColumnCount();
         for (; baseTableColumn &lt; totalColumns; baseTableColumn++) {
-            if (resultSetMetaData_.sqlxSchema_[baseTableColumn] != null)
+            if (resultSetMetaData_.sqlxBasename_[baseTableColumn] != null)
                 break;
         }
 
@@ -3142,11 +3142,6 @@
         if (baseTableColumn == totalColumns)
             baseTableColumn = 0;
 
-        if (resultSetMetaData_.sqlxRdbnam_[baseTableColumn] != null &amp;&amp;
-                !resultSetMetaData_.sqlxRdbnam_[baseTableColumn].equals(""))      // catalog
-        {
-            tableName += "\"" + resultSetMetaData_.sqlxRdbnam_[baseTableColumn] + "\".";
-        }
         //dervied column like select 2 from t1, has null schema and table name
         if (resultSetMetaData_.sqlxSchema_[baseTableColumn] != null &amp;&amp; !resultSetMetaData_.sqlxSchema_[baseTableColumn].equals(""))
{
             tableName += "\"" + resultSetMetaData_.sqlxSchema_[baseTableColumn] + "\".";
  </pre>
    </blockquote>
  </blockquote>
  </div>
  <br>
</blockquote>
</body>
</html>


Mime
View raw message