db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Satheesh Bandaram <sathe...@Sourcery.Org>
Subject Re: [jira] Commented: (DERBY-217) issue with BLOBs and batch updates in 10.1.0.0
Date Wed, 08 Jun 2005 00:27:39 GMT
<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
<html>
<head>
  <meta content="text/html;charset=ISO-8859-1" http-equiv="Content-Type">
  <title></title>
</head>
<body bgcolor="#ffffff" text="#000000">
I have briefly looked at the large test... Would it be ok to modify the
test next week, after the release? The patch corrects the problem being
reported and I will run the regular tests. I will keep the bug open
until a test is added here..<br>
<br>
Here is the diff. Let me know if anyone has any comments. I have also
attached the patch to Jira entry.<br>
<br>
Satheesh<br>
<br>
Index: SQLBlob.java<br>
===================================================================<br>
--- SQLBlob.java&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; (revision
180460)<br>
+++ SQLBlob.java&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; (working
copy)<br>
@@ -187,8 +187,15 @@<br>
&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;
return TypeId.BLOB_PRECEDENCE; // not really
used<br>
&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;
}<br>
<br>
-&nbsp;&nbsp;&nbsp; public void setInto(PreparedStatement ps, int position) throws
SQLExcepti<br>
, StandardException {<br>
-&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; ps.setBlob(position,null);<br>
+&nbsp;&nbsp;&nbsp; public void setInto(PreparedStatement ps, int position)<br>
+&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;
throws SQLException, StandardException<br>
+&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; {<br>
+&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;
if (isNull()) {<br>
+&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;
ps.setBlob(position, null);<br>
+&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;
return;<br>
+&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;
}<br>
+<br>
+&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;
ps.setBytes(position, getBytes());<br>
&nbsp;&nbsp;&nbsp;&nbsp; }<br>
&nbsp;}<br>
<br>
Daniel John Debrunner wrote:<br>
<blockquote cite="mid42A60E6F.9040705@debrunners.com" type="cite">
  <pre wrap="">Satheesh Bandaram (JIRA) wrote:

  </pre>
  <blockquote type="cite">
    <pre wrap="">    [ <a class="moz-txt-link-freetext" href="http://issues.apache.org/jira/browse/DERBY-217?page=comments#action_12312921">http://issues.apache.org/jira/browse/DERBY-217?page=comments#action_12312921</a>
] 

Satheesh Bandaram commented on DERBY-217:
-----------------------------------------

I think this bug is a regression caused by the fix for:

Derby-174 &amp; Derby-175: Make setNull work with Timestamp and Blob datatypes.

Submitted by Shreyas Kaushik (<a class="moz-txt-link-abbreviated" href="mailto:Shreyas.Kaushik@Sun.COM">Shreyas.Kaushik@Sun.COM</a>)

If I rollback the fix in my setup, the passes as expected. I believe the setInto() methods
added for SQLBlob and SQLTimestamp are incorrect.

    </pre>
  </blockquote>
  <pre wrap=""><!---->
Fixing this should include adding batch testing of valid values to
jdbcapi/parameterMapping. I can help with this testing if needed.

Dan.




  </pre>
</blockquote>
</body>
</html>


Mime
View raw message