db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Kathey Marsden <kmarsdende...@sbcglobal.net>
Subject Re: [jira] Commented: (DERBY-128) Network Server Gives NPE if SQLException has null arguments (e.g. for ERROR XBM0H)
Date Sat, 04 Jun 2005 20:38:34 GMT
Dyre.Tjeldvoll@Sun.COM wrote:

>OK. From the description of DERBY-19 it looked like it could be the
>same. But when I looked at the diff for 178795 I could not really see
>how it could fix DERBY-128.
>
>  
>
As I see it there are two core issues

 1) Network Server shouldn't throw an NPE if an SQLException as null
arguments.
     You fixed this and I think  your test change is probably good for
testing that.

2)  An SQLException shouldn't  have null arguments.  It should have the
same number of meaningful arguments as there are {} markers in the
messages_en.properties  file.
     For DERBY-19, it looks like Dan changed a null argument to a
meaningful argument. 
     For the exception listed in DERBY-128 (XBM0H:) it looks like the
exception requires only one argument but we were
      calling the wrong method and passing an extra null argument along
the way.

The problem is that once  you fix all the instances of issue 2,  issue 1
is no longer an issue #:). So,  I think there is no long term test
solution here.

So I would say
 
 File a bug for the XBM0H exception  being generated with null
arguments.   File a patch plus your NSinSameJVM test.
The  NSinSameJVM test will  be a good test of a hard to test
exception.   I think you need security manager to reproduce and only the
network server tests run with security manager.  Embedded gets tested
because network server just makes embedded calls.

As for the funny characters, that is DERBY-285 and on my list to fix
this weekend so I better go do that now #:)

Kathey





Mime
View raw message