db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Satheesh Bandaram <sathe...@Sourcery.Org>
Subject Re: DERBY-318(Re: DERBY-308 just be done and .... (Re: [jira] Updated: (DERBY-308) Modify dblook to support "GENERATED BY DEFAULT AS IDENTITY"))
Date Sat, 04 Jun 2005 17:43:21 GMT
<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
<html>
<head>
  <meta content="text/html;charset=ISO-8859-1" http-equiv="Content-Type">
  <title></title>
</head>
<body bgcolor="#ffffff" text="#000000">
You are correct... The failed tests dataSourcePermissions_net and
OnlineCompressTest are not because of your change. Someone else is
investigating those. You don't have to worry about them. <span
 class="moz-smiley-s1"><span> :-) </span></span><br>
<br>
Satheesh<br>
<br>
TomohitoNakayama wrote:<br>
<blockquote cite="mid002b01c568f0$63657380$2000a8c0@Arkat" type="cite">
  <title></title>
  <meta http-equiv="Content-Type" content="text/html;charset=ISO-8859-1">
  <meta content="MSHTML 6.00.2900.2627" name="GENERATOR">
  <style></style>
  <div><font face="MS UI Gothic" size="2">Hello.</font></div>
  <div>&nbsp;</div>
  <div><font face="MS UI Gothic" size="2">Thank you for finishing
DERBY-318 and 308 !</font></div>
  <div>&nbsp;</div>
  <div>&nbsp;</div>
  <div><font face="MS UI Gothic" size="2">I had continued testing
DERBY-318.</font></div>
  <div>&nbsp;</div>
  <div><font face="MS UI Gothic" size="2">Before, I found errors in
next three test with modification of DERBY-318.</font></div>
  <div><font face="MS UI Gothic" size="2">&nbsp;derbyall/derbynetclientmats/DerbyNetClient/derbynetmats/derbynetmats/dataSourcePermissions_net</font></div>
  <div><font face="MS UI Gothic" size="2">&nbsp;derbyall/derbynetclientmats/DerbyNetClient/derbynetmats/derbynetmats/updatableResultSet</font></div>
  <div><font face="MS UI Gothic" size="2">&nbsp;derbyall/storeall/storemore/OnlineCompressTest</font></div>
  <div>&nbsp;</div>
  <div><font face="MS UI Gothic" size="2">I ran derbyall without
modification of DERBY-318&nbsp;and error was found only in
"updatableResultSet.diff".</font></div>
  <div>&nbsp;</div>
  <div><font face="MS UI Gothic" size="2">Hence , </font></div>
  <div><font face="MS UI Gothic" size="2">errors in</font></div>
  <div><font face="&#65325;&#65331; &#65328;&#12468;&#12471;&#12483;&#12463;"
size="2">&nbsp;dataSourcePermissions_net and</font></div>
  <div><font face="&#65325;&#65331; &#65328;&#12468;&#12471;&#12483;&#12463;"
size="2">&nbsp;OnlineCompressTest.java ,</font></div>
  <div><font face="&#65325;&#65331; &#65328;&#12468;&#12471;&#12483;&#12463;"
size="2">might be caused by modification
of DERBY-318.</font></div>
  <div>&nbsp;</div>
  <div><font face="MS UI Gothic" size="2">To know much about errors, </font></div>
  <div><font face="&#65325;&#65331; &#65328;&#12468;&#12471;&#12483;&#12463;"
size="2"><font face="MS UI Gothic">I ran
tests with modification of DERBY-318 individually.</font></font></div>
  <div><font face="MS UI Gothic" size="2">However, none of these test
failed in individual testing.</font></div>
  <div>&nbsp;</div>
  <div>&nbsp;</div>
  <div><font face="MS UI Gothic" size="2">I conclude errors found in
derbyall after modification of DERBY-318&nbsp; happen indeterminately and, </font></div>
  <div><font face="MS UI Gothic" size="2">they does not imply
regression by DERBY-318</font><font face="MS UI Gothic" size="2">.</font></div>
  <div>&nbsp;</div>
  <div>&nbsp;</div>
  <div><font face="MS UI Gothic" size="2">Best regards.</font></div>
  <div>&nbsp;</div>
  <div>&nbsp;</div>
  <div>/*</div>
  <div>&nbsp;</div>
  <div>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;
Tomohito Nakayama<br>
&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; <a href="mailto:tomonaka@basil.ocn.ne.jp">tomonaka@basil.ocn.ne.jp</a><br>
&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; <a href="mailto:tomohito@rose.zero.ad.jp">tomohito@rose.zero.ad.jp</a></div>
  <div>&nbsp;</div>
  <div>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;
Naka<br>
&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; <a href="http://www5.ocn.ne.jp/%7Etomohito/TopPage.html">http://www5.ocn.ne.jp/~tomohito/TopPage.html</a></div>
  <div>&nbsp;</div>
  <div>*/</div>
  <blockquote
 style="border-left: 2px solid rgb(0, 0, 0); padding-right: 0px; padding-left: 5px; margin-left:
5px; margin-right: 0px;">
    <div
 style="font-family: MS UI Gothic; font-style: normal; font-variant: normal; font-weight:
normal; font-size: 10pt; line-height: normal; font-size-adjust: none; font-stretch: normal;">-----
Original Message ----- </div>
    <div
 style="background: rgb(228, 228, 228) none repeat scroll 0%; -moz-background-clip: initial;
-moz-background-origin: initial; -moz-background-inline-policy: initial; font-family: MS UI
Gothic; font-style: normal; font-variant: normal; font-weight: normal; font-size: 10pt; line-height:
normal; font-size-adjust: none; font-stretch: normal;"><b>From:</b>
    <a title="satheesh@Sourcery.Org" href="mailto:satheesh@Sourcery.Org">Satheesh
Bandaram</a> </div>
    <div
 style="font-family: MS UI Gothic; font-style: normal; font-variant: normal; font-weight:
normal; font-size: 10pt; line-height: normal; font-size-adjust: none; font-stretch: normal;"><b>To:</b>
    <a title="derby-dev@db.apache.org"
 href="mailto:derby-dev@db.apache.org">Derby Development</a> </div>
    <div
 style="font-family: MS UI Gothic; font-style: normal; font-variant: normal; font-weight:
normal; font-size: 10pt; line-height: normal; font-size-adjust: none; font-stretch: normal;"><b>Sent:</b>
Friday, June 03, 2005 12:05 PM</div>
    <div
 style="font-family: MS UI Gothic; font-style: normal; font-variant: normal; font-weight:
normal; font-size: 10pt; line-height: normal; font-size-adjust: none; font-stretch: normal;"><b>Subject:</b>
Re: DERBY-318(Re: DERBY-308 just be done and .... (Re: [jira] Updated:
(DERBY-308) Modify dblook to support "GENERATED BY DEFAULT AS
IDENTITY"))</div>
    <div><br>
    </div>
Hi Tomohito,<br>
    <br>
Once I applied both your patches, I found some problems. The problems
were:<br>
    <ol>
      <li>We needed to update dblook_test_net.out in both DerbyNet and
DerbyNetClient directories. </li>
      <li>Found a small problem in dblook itself. It was generating
default info for identity columns also, since toString() now returns
GENERATED_BY_DEFAULT string. dblook needed to be modified. </li>
    </ol>
I applied the changes already. I think everything should be fine now.
Please look at my changes below. If they are incorrect, feel free to
send another patch. You can see the actual changes by: <b>svn diff
-r179707:179708</b><br>
    <br>
Satheesh<br>
    <br>
Sending&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;
java\testing\org\apache\derbyTesting\functionTests\master\DerbyNet\dblook_test_net.out<br>
Sending&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;
java\testing\org\apache\derbyTesting\functionTests\master\DerbyNetClient\dblook_test_net.out<br>
Sending&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;
java\testing\org\apache\derbyTesting\functionTests\master\dblook_test.out<br>
Sending&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;
java\tools\org\apache\derby\impl\tools\dblook\DB_Table.java<br>
Transmitting file data ....<br>
Committed revision 179708.<br>
    <br>
TomohitoNakayama wrote:<br>
    <blockquote cite="mid000701c5675e$42d9bd80$2000a8c0@Arkat"
 type="cite">Hello. <br>
      <br>
Thank you. <br>
      <br>
I have uploaded patch. <br>
There found three error in result of derbyall. <br>
      <br>
I don't think they are caused by my modification... <br>
I will execute derbyall again and confirm it. <br>
      <br>
Best regards. <br>
      <br>
/* <br>
      <br>
&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; Tomohito Nakayama <br>
&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; <a class="moz-txt-link-abbreviated"
 href="mailto:tomonaka@basil.ocn.ne.jp">tomonaka@basil.ocn.ne.jp</a> <br>
&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; <a class="moz-txt-link-abbreviated"
 href="mailto:tomohito@rose.zero.ad.jp">tomohito@rose.zero.ad.jp</a> <br>
      <br>
&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; Naka <br>
&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; <a class="moz-txt-link-freetext"
 href="http://www5.ocn.ne.jp/%7Etomohito/TopPage.html">http://www5.ocn.ne.jp/~tomohito/TopPage.html</a>
      <br>
      <br>
*/ <br>
----- Original Message ----- From: "Army" <a
 class="moz-txt-link-rfc2396E" href="mailto:qozinx@sbcglobal.net">&lt;qozinx@sbcglobal.net&gt;</a>
      <br>
To: "Derby Development" <a class="moz-txt-link-rfc2396E"
 href="mailto:derby-dev@db.apache.org">&lt;derby-dev@db.apache.org&gt;</a>
      <br>
Sent: Thursday, June 02, 2005 1:04 AM <br>
Subject: Re: DERBY-318(Re: DERBY-308 just be done and .... (Re: [jira]
Updated: (DERBY-308) Modify dblook to support "GENERATED BY DEFAULT AS
IDENTITY")) <br>
      <br>
      <br>
      <blockquote type="cite">TomohitoNakayama wrote: <br>
        <br>
        <blockquote type="cite">I concluded as next. <br>
Thinking "GENERATED BY DEFAULT AS IDENTITY" is a kind of default, <br>
returning not null value for that column does not cause problem. <br>
On the contrast , returning null value for column of "GENERATED BY
DEFAULT AS IDENTITY" <br>
may cause some inconsistency, because the column is a column with
special default value. <br>
          <br>
        </blockquote>
        <br>
Well, a GENERATED ALWAYS AS IDENTITY column is also "a column with
special default value", and yet Derby currently returns null for the
default of that kind of column.&nbsp; So to make GENERATED BY DEFAULT
columns match this behavior (by returning null) is, I think, the most
consistent thing. <br>
        <br>
On the other hand, I agree that a non-null string such as
"GENERATED_BY_DEFAULT" has its benefits, as well.&nbsp; Since no one else
has commented one way or the other, and since I think we should get
this issue resolved sooner rather than later, I think you can go ahead
and do things the way you think is best. <br>
        <br>
So please feel free to make the change as you prefer, and to post the
patch to the list so we can proceed. <br>
        <br>
Thanks! <br>
Army <br>
        <br>
        <br>
        <br>
        <br>
--&nbsp;<br>
No virus found in this incoming message. <br>
Checked by AVG Anti-Virus. <br>
Version: 7.0.322 / Virus Database: 267.4.0 - Release Date: 2005/06/01 <br>
        <br>
        <br>
      </blockquote>
      <br>
      <br>
      <br>
    </blockquote>
    <p> </p>
    <hr> No virus found in this incoming message.<br>
Checked by AVG Anti-Virus.<br>
Version: 7.0.323 / Virus Database: 267.6.1 - Release Date: 2005/06/03<br>
  </blockquote>
  <pre wrap="">
<hr size="4" width="90%">
No virus found in this outgoing message.
Checked by AVG Anti-Virus.
Version: 7.0.323 / Virus Database: 267.6.1 - Release Date: 2005/06/03
  </pre>
</blockquote>
</body>
</html>


Mime
View raw message