db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Satheesh Bandaram <sathe...@Sourcery.Org>
Subject Re: DERBY-318(Re: DERBY-308 just be done and ....
Date Fri, 03 Jun 2005 01:25:51 GMT
This patch is committed. Thanks!

Satheesh

Sending       
java\testing\org\apache\derbyTesting\functionTests\master\dblook_test.out
Sending       
java\testing\org\apache\derbyTesting\functionTests\tests\tools\dblook_makeDB.sql
Sending        java\tools\org\apache\derby\impl\tools\dblook\DB_Table.java
Transmitting file data ...
Committed revision 179693.

TomohitoNakayama wrote:

> Hello.
>
> Thank you.
>
> I have uploaded patch.
> There found three error in result of derbyall.
>
> I don't think they are caused by my modification...
> I will execute derbyall again and confirm it.
>
> Best regards.
>
> /*
>
>         Tomohito Nakayama
>         tomonaka@basil.ocn.ne.jp
>         tomohito@rose.zero.ad.jp
>
>         Naka
>         http://www5.ocn.ne.jp/~tomohito/TopPage.html
>
> */
> ----- Original Message ----- From: "Army" <qozinx@sbcglobal.net>
> To: "Derby Development" <derby-dev@db.apache.org>
> Sent: Thursday, June 02, 2005 1:04 AM
> Subject: Re: DERBY-318(Re: DERBY-308 just be done and .... (Re: [jira]
> Updated: (DERBY-308) Modify dblook to support "GENERATED BY DEFAULT AS
> IDENTITY"))
>
>
>> TomohitoNakayama wrote:
>>
>>> I concluded as next.
>>> Thinking "GENERATED BY DEFAULT AS IDENTITY" is a kind of default,
>>> returning not null value for that column does not cause problem.
>>> On the contrast , returning null value for column of "GENERATED BY
>>> DEFAULT AS IDENTITY"
>>> may cause some inconsistency, because the column is a column with
>>> special default value.
>>>
>>
>> Well, a GENERATED ALWAYS AS IDENTITY column is also "a column with
>> special default value", and yet Derby currently returns null for the
>> default of that kind of column.  So to make GENERATED BY DEFAULT
>> columns match this behavior (by returning null) is, I think, the most
>> consistent thing.
>>
>> On the other hand, I agree that a non-null string such as
>> "GENERATED_BY_DEFAULT" has its benefits, as well.  Since no one else
>> has commented one way or the other, and since I think we should get
>> this issue resolved sooner rather than later, I think you can go
>> ahead and do things the way you think is best.
>>
>> So please feel free to make the change as you prefer, and to post the
>> patch to the list so we can proceed.
>>
>> Thanks!
>> Army
>>
>>
>>
>>
>> -- 
>> No virus found in this incoming message.
>> Checked by AVG Anti-Virus.
>> Version: 7.0.322 / Virus Database: 267.4.0 - Release Date: 2005/06/01
>>
>>
>
>
>


Mime
View raw message