db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Army <qoz...@sbcglobal.net>
Subject Re: [jira] Updated: (DERBY-318) SYS.SYSCOLUMN problem with "GENERATED BY DEFAULT" column w/ Network Server
Date Thu, 02 Jun 2005 16:12:47 GMT
Tomohito Nakayama (JIRA) wrote:
>      [ http://issues.apache.org/jira/browse/DERBY-318?page=all ]
> 
> Tomohito Nakayama updated DERBY-318:
> ------------------------------------
> 
>     Attachment: DERBY-318.patch
> 
> Modified:
> 1:
> SYSCOLUMNS.COLUMNDEFAULT have "GENERATED_BY_DEFAULT", 
> if the SYSCOLUMNS record stands for default autoinc column.
> 2:
> Test for 1: was added to lang/syscat.sql.
> 3:
> lang/syscat.sql became to executed in derbynetmats.runall.
> This results addition of syscat.sql to both of derbynet and derbynetclient.

Tomohito,

Thanks for submitting this patch and for adding a new test case to syscat.sql.

I successfully applied the patch to a clean codeline and ran lang/syscat.sql in 
1) embedded mode, 2) server mode with JCC, and 3)server mode with Derby 
Client--and all passed.  I also tried running the test withOUT your change to 
DefaultInfoImpl, and the tests failed as expected.

SO, this looks good to me: +1.

> Testing:
> Executed derbyall and found three error.

I agree that the three errors are not related to your changes:

1 - derbynetmats/dataSourcePermission_net:
Filed as DERBY-273.

2 - derbynetmats/updatableResultSet:
Filed as DERBY-320.

3 - store/OnlineCompressTests:
Probably related to the following thread?
http://thread.gmane.org/gmane.comp.apache.db.derby.devel/4775

Thanks again for the patch.  Unless someone else has comments, could a committer 
please commit?

+1
Army


Mime
View raw message