db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Daniel John Debrunner <...@debrunners.com>
Subject Re: [PATCH] Derby-156
Date Thu, 02 Jun 2005 15:33:57 GMT
Mamta Satoor wrote:

> Hi Shreyas,
> In order to avoid one assignment, the code is having to instantiate a
> new object and do an if check on it and then do the assignment. I am not
> sure if we should go through all this extra code when an additional
> comment can describe what is the assignment for.

Mamta, where does the new object assignment come in, I couldn't see one
in the extract you commented on?

Though I would agree with Mamta that avoiding the assignment is not
really required since this is compile time code, micro-optimizing
compile time code has not been a focus of Derby/Cloudscape in the past.
If the simple assignment is correct, simpler and less code then it is
the preferred approach for compile time code. Even for execute time code
one needs to balance the clarity of the code over the performance benefit.


View raw message