db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bernt M. Johnsen" <Bernt.John...@sun.com>
Subject Re: [PATCH] (DERBY-276) ResultSet.relative(int row) cannot be called when the cursor is not positioned on a row.
Date Fri, 10 Jun 2005 07:30:46 GMT
>>>>>>>>>>>> Myrna van Lunteren wrote (2005-06-09 14:20:39):
> Oh - maybe better to attach your next patch to the bug?

I should of course have done that. 

But, then, shouldn't all patches be attached to a Jira issue? Today
both mailing the patch and attaching the patch to a Jira issue is
praticed. (And if there is no Jira issue for a patch, an issue should
definitely be created).

> Myrna
> 
> 
>  On 6/9/05, Myrna van Lunteren <m.v.lunteren@gmail.com> wrote: 
> > 
> > On 6/8/05, Bernt M. Johnsen <Bernt.Johnsen@sun.com> wrote: 
> > > 
> > > >>>>>>>>>>>> Bernt M. Johnsen wrote (2005-05-27
14:31:39):
> > > > Could anybody review this? 
> > > 
> > > Well?
> > > 
> > > > This patch will make relative() allowed when the cursor is before
> > > > first or after last. It will also let absolute(0) be equivalent to
> > > > beforeFirst().
> > > [..snip..]
> > 
> >   Well, well! 
> > I applied the patch without trouble (I feared it would be out of date 
> > already :-) ), built without trouble. It all looks reasonable to me.
> > However, your patch doesn't include a modified master for scrollCursors2?
> > Did you run derbyall?
> >  Could this change create trouble for any existing applications? i.e. What 
> > if someone has programmed an app to do relative(1) in a loop, breaking out 
> > when the exception is hit?
> >  Thx,
> > Myrna
> >

-- 
Bernt Marius Johnsen, Database Technology Group, 
Sun Microsystems, Trondheim, Norway

Mime
View raw message