db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dag H. Wanvik" <Dag.Wan...@Sun.COM>
Subject Re: [PATCH] (Derby-331) create table fails when a constraint defintion follows a column default
Date Wed, 15 Jun 2005 01:26:41 GMT

Hi Mamta,

Thanks for reviewing this!
>>>>> "MS" == Mamta Satoor <msatoor@gmail.com> wrote:
MS> 
MS> Oh, just one minor thing. I think a comment in the code as to why we have 
MS> (getToken(4).kind == LEFT_PAREN && getToken(2).kind != COMMA)} ) might help

MS> a future developer understand the code.

Yes, I definitely agree. I'll do that and post an updated patch.

Dag


MS>  thanks,
MS> Mamta
MS> 
MS> 
MS>  On 6/13/05, Mamta Satoor <msatoor@gmail.com> wrote: 
MS> > 
MS> > Hi Dag,
MS> >  I looked at the patch and it looks good to me.
MS> >  thanks,
MS> > Mamta
MS> > 
MS> >  On 6/10/05, Dag H. Wanvik <Dag.Wanvik@sun.com> wrote: 
MS> > > 
MS> > > Hi,
MS> > > 
MS> > > I just uploaded a patch for this issue. Can somebody review it please?
MS> > > It's small.
MS> > > 
MS> > > Dag 
MS> > > 
MS> > 
MS> >
MS> <div>Oh, just one minor thing.&nbsp;I think a comment in the code as to&nbsp;why
we have (getToken(4).kind == LEFT_PAREN &amp;&amp; getToken(2).kind != COMMA)} ) might
help a future developer understand the code.</div>
MS> <div>&nbsp;</div>
MS> <div>thanks,</div>
MS> <div>Mamta<br><br><br>&nbsp;</div>
MS> <div><span class="gmail_quote">On 6/13/05, <b class="gmail_sendername">Mamta
Satoor</b> &lt;<a href="mailto:msatoor@gmail.com">msatoor@gmail.com</a>&gt;
wrote:</span>
MS> <blockquote class="gmail_quote" style="PADDING-LEFT: 1ex; MARGIN: 0px 0px 0px 0.8ex;
BORDER-LEFT: #ccc 1px solid">
MS> <div>Hi Dag,</div>
MS> <div>&nbsp;</div>
MS> <div>I looked at the patch and it looks good to me.</div>
MS> <div>&nbsp;</div>
MS> <div>thanks,</div><span class="sg">
MS> <div>Mamta<br><br>&nbsp;</div></span>
MS> <div><span class="e" id="q_10476e7df6231a47_2">
MS> <div><span class="gmail_quote">On 6/10/05, <b class="gmail_sendername">Dag
H. Wanvik</b> &lt;<a onclick="return top.js.OpenExtLink(window,event,this)" href="mailto:Dag.Wanvik@sun.com"
target="_blank">Dag.Wanvik@sun.com</a>
MS> &gt; wrote:</span> 
MS> <blockquote class="gmail_quote" style="PADDING-LEFT: 1ex; MARGIN: 0px 0px 0px 0.8ex;
BORDER-LEFT: #ccc 1px solid">Hi,<br><br>I just uploaded a patch for this issue.
Can somebody review it please?<br>It's small.<br><br>Dag 
MS> <br></blockquote></div><br></span></div></blockquote></div><br>
MS> 
-- 
Dag H. Wanvik
Sun Microsystems, Web Services, Database Technology Group
Haakon VII gt. 7b, N-7485 Trondheim, Norway
Tel: x43496/+47 73842196, Fax:  +47 73842101

~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 
NOTICE: This email message is for the sole use of the intended
recipient(s) and may contain confidential and privileged
information. Any unauthorized review, use, disclosure or distribution
is prohibited. If you are not the intended recipient, please contact
the sender by reply email and destroy all copies of the original
message.
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 

Mime
View raw message