Return-Path: Delivered-To: apmail-db-derby-dev-archive@www.apache.org Received: (qmail 64418 invoked from network); 4 May 2005 19:34:22 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur.apache.org with SMTP; 4 May 2005 19:34:22 -0000 Received: (qmail 81385 invoked by uid 500); 4 May 2005 19:35:41 -0000 Delivered-To: apmail-db-derby-dev-archive@db.apache.org Received: (qmail 81317 invoked by uid 500); 4 May 2005 19:35:41 -0000 Mailing-List: contact derby-dev-help@db.apache.org; run by ezmlm Precedence: bulk list-help: list-unsubscribe: List-Post: List-Id: Reply-To: "Derby Development" Delivered-To: mailing list derby-dev@db.apache.org Received: (qmail 81269 invoked by uid 99); 4 May 2005 19:35:39 -0000 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests=RCVD_BY_IP X-Spam-Check-By: apache.org Received-SPF: pass (hermes.apache.org: domain of msatoor@gmail.com designates 64.233.184.206 as permitted sender) Received: from wproxy.gmail.com (HELO wproxy.gmail.com) (64.233.184.206) by apache.org (qpsmtpd/0.28) with ESMTP; Wed, 04 May 2005 12:35:39 -0700 Received: by wproxy.gmail.com with SMTP id 58so427795wri for ; Wed, 04 May 2005 12:32:58 -0700 (PDT) DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:reply-to:to:subject:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=pETfTjkAKaAygwISYc3uKyHYC0VRCT2R88BMeExmGqgCM0yyDY3G3Q9aiWz01VIrjHQKLegbZp7A5vP0Z3OjX+xytsBEJJwRybQ2CBd8eAavbGrTMhjiUTfL1i0MeLgFZVmloCwloJkGm3ExodJ+/0E0SUucdGMxCqtmrkdSmrY= Received: by 10.54.79.15 with SMTP id c15mr290886wrb; Wed, 04 May 2005 12:32:58 -0700 (PDT) Received: by 10.54.49.63 with HTTP; Wed, 4 May 2005 12:32:58 -0700 (PDT) Message-ID: Date: Wed, 4 May 2005 12:32:58 -0700 From: Mamta Satoor Reply-To: Mamta Satoor To: Derby Development Subject: Re: [jira] Created: (DERBY-242) DatabaseMetaData.supportsGetGeneratedKeys needs to return FALSE, since Derby only has limited support. In-Reply-To: <42791864.7050502@sun.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Content-Disposition: inline References: <1350636386.1114562363875.JavaMail.jira@ajax.apache.org> <42729A0C.9060503@sun.com> <4279173A.4090009@Sun.COM> <42791864.7050502@sun.com> X-Virus-Checked: Checked X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N Hi Lance, I looked at the review package and it looks good. Good comments in the EmbedDatabaseMetaData.java. Just wondered if you ran the existing tests to make sure nothing got affected by the change. Mamta On 5/4/05, Lance J. Andersen wrote: > Oh, I forgot to mention that i validated that the dbMetaDataJdbc30 in jdk= 14 > passed. >=20 >=20 >=20 > Lance Andersen wrote: >=20 > Attached is the patch.=20 >=20 > Regards=20 > Lance=20 >=20 > Mamta Satoor wrote:=20 > Hi Lance,=20 >=20 > Thanks for taking it. Yes, it is for Embedded Driver.=20 >=20 > Mamta=20 >=20 > On 4/29/05, Lance J. Andersen wrote:=20 >=20 > I take it this is with the Embedded Driver as it looks like the code for = the > new Client Driver is returning false.=20 >=20 > I can take this if no one else wants it.=20 >=20 >=20 > Mamta Satoor wrote:=20 > Hi,=20 >=20 >=20 > I think this is a very easy bug to fix. So, if someone is looking=20 >=20 > for=20 >=20 > an opportunity to start with a simple bug, this will be a good=20 >=20 > one.=20 >=20 >=20 > Mamta=20 >=20 > On 4/26/05, Satheesh Bandaram (JIRA) =20 >=20 > wrote:=20 >=20 > =20 >=20 > DatabaseMetaData.supportsGetGeneratedKeys needs to return=20 > FALSE, since Derby only has limited=20 > support.=20 >=20 > -------------------------------------------------------------------------= ----------------------------- >=20 >=20 > Key: DERBY-242=20 >=20 > URL:=20 >=20 > http://issues.apache.org/jira/browse/DERBY-242=20 >=20 > Project:=20 >=20 > Derby=20 >=20 > Type: Bug=20 > Components: JDBC=20 > Versions: 10.0.2.0=20 > Environment: ALL=20 >=20 > Reporter: Satheesh Bandaram=20 >=20 > Assigned to: Satheesh Bandaram=20 > Fix For:=20 >=20 > 10.1.0.0=20 >=20 >=20 > Derby only has partial support for retrieving generated=20 >=20 > values.=20 >=20 > Because of this, it is desirable to=20 >=20 > make=20 >=20 > DatabaseMetaData.supportsGetGeneratedKeys return=20 >=20 > FALSE. One=20 >=20 > of the restrictions include Jira entry Derby-201. Till this=20 >=20 > is=20 >=20 > fixed, we should change derby to return FALSE for this.=20 >=20 > This would also=20 >=20 > match Derby client behavior.=20 >=20 >=20 > --=20 > This message is automatically generated by=20 >=20 > JIRA.=20 >=20 > -=20 > If you think it was sent incorrectly contact one of the=20 >=20 > administrators:=20 > http://issues.apache.org/jira/secure/Administrators.jspa=20 >=20 > -=20 > For=20 >=20 > more information on JIRA, see:=20 > http://www.atlassian.com/software/jira=20 >=20 >=20 > =20 >=20 > =20 >=20 >=20 >=20 > ________________________________ >=20 Index: > java/engine/org/apache/derby/impl/jdbc/EmbedDatabaseMetaData.java =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D --- > java/engine/org/apache/derby/impl/jdbc/EmbedDatabaseMetaData.java > (revision 168122) +++ > java/engine/org/apache/derby/impl/jdbc/EmbedDatabaseMetaData.java > (working copy) @@ -2880,7 +2880,13 @@ */ public boolean > supportsGetGeneratedKeys() { - return true; + /* + * Currently reverting > the returned value to false until there=20 + * is more support for > autogenerated keys in Derby. + * (such as support for specifying the > returned columns for + * the autogenerated key) + */ + return false; } =20 > /** Index: > java/testing/org/apache/derbyTesting/functionTests/master/dbMetaDataJdbc3= 0.out =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D --- > java/testing/org/apache/derbyTesting/functionTests/master/dbMetaDataJdbc3= 0.out > (revision 168122) +++ > java/testing/org/apache/derbyTesting/functionTests/master/dbMetaDataJdbc3= 0.out > (working copy) @@ -4,7 +4,7 @@ supportsSavepoints() : true > supportsNamedParameters() : false supportsMultipleOpenResults() : > true -supportsGetGeneratedKeys() : true +supportsGetGeneratedKeys() : false > supportsResultSetHoldability(HOLD_CURSORS_OVER_COMMIT) : > true supportsResultSetHoldability(CLOSE_CURSORS_AT_COMMIT) > : true getJDBCMajorVersion() : 3 =20 >