Return-Path: Delivered-To: apmail-db-derby-dev-archive@www.apache.org Received: (qmail 60067 invoked from network); 12 May 2005 20:46:12 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur.apache.org with SMTP; 12 May 2005 20:46:12 -0000 Received: (qmail 87799 invoked by uid 500); 12 May 2005 20:50:21 -0000 Delivered-To: apmail-db-derby-dev-archive@db.apache.org Received: (qmail 87763 invoked by uid 500); 12 May 2005 20:50:20 -0000 Mailing-List: contact derby-dev-help@db.apache.org; run by ezmlm Precedence: bulk list-help: list-unsubscribe: List-Post: List-Id: Reply-To: "Derby Development" Delivered-To: mailing list derby-dev@db.apache.org Received: (qmail 87749 invoked by uid 99); 12 May 2005 20:50:20 -0000 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests= X-Spam-Check-By: apache.org Received-SPF: neutral (hermes.apache.org: 32.97.110.130 is neither permitted nor denied by domain of suresh.thalamati@gmail.com) Received: from e32.co.us.ibm.com (HELO e32.co.us.ibm.com) (32.97.110.130) by apache.org (qpsmtpd/0.28) with ESMTP; Thu, 12 May 2005 13:50:20 -0700 Received: from d03relay04.boulder.ibm.com (d03relay04.boulder.ibm.com [9.17.195.106]) by e32.co.us.ibm.com (8.12.10/8.12.9) with ESMTP id j4CKk80c784552 for ; Thu, 12 May 2005 16:46:08 -0400 Received: from d03av04.boulder.ibm.com (d03av04.boulder.ibm.com [9.17.195.170]) by d03relay04.boulder.ibm.com (8.12.10/NCO/VER6.6) with ESMTP id j4CKk7W4210830 for ; Thu, 12 May 2005 14:46:07 -0600 Received: from d03av04.boulder.ibm.com (loopback [127.0.0.1]) by d03av04.boulder.ibm.com (8.12.11/8.13.3) with ESMTP id j4CKk7t5018427 for ; Thu, 12 May 2005 14:46:07 -0600 Received: from [127.0.0.1] (tsuresh.svl.ibm.com [9.30.40.238]) by d03av04.boulder.ibm.com (8.12.11/8.12.11) with ESMTP id j4CKk6gK018331 for ; Thu, 12 May 2005 14:46:07 -0600 Message-ID: <4283C08A.4090001@gmail.com> Date: Thu, 12 May 2005 13:46:02 -0700 From: Suresh Thalamati User-Agent: Mozilla Thunderbird 1.0 (Windows/20041206) X-Accept-Language: en-us, en MIME-Version: 1.0 To: Derby Development Subject: Re: [PATCH] Derby 236 BootPassword gets written out in plain text in sane mode and in our test environment. References: <428243AB.1040004@gmail.com> <4283A1A6.8030609@sbcglobal.net> <4283A6B6.2060602@gmail.com> <4283AA79.90205@gmail.com> <4283AB3E.6080805@gmail.com> In-Reply-To: <4283AB3E.6080805@gmail.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N Sunitha Kambhampati wrote: > Sunitha Kambhampati wrote: > >> Suresh Thalamati wrote: >> >>> - Why is password hard coded in the test harness code, is it not >>> possible to specify it as test property ? for eg on the db URL itself. >>> + String encryptUrl = >>> "dataEncryption=true;bootPassword=Thursday"; >>> >> Well, I didnt particularly like to hardcode it this way, but I looked >> at the rest of the test harness ( see encryptionProtocol in RunTest >> and the bootPassword is hardcoded to Thursday) and I followed the >> same approach for MultiTest. >> >> This issue about reading the bootPassword as a property (ie >> testDataEncryption) seems to be an improvement to the test harness >> and I think it is not related to this fix in general which was why I >> chose not to make changes to the test harness. >> >> But if you feel strongly otherwise please let me know. >> >> > If you agree, I will file a jira entry for this. > > Thanks, > Sunitha. > > Thanks for the explanation, please file a jira entry. Hard coding passwords in the harness code will make it difficult to to add a new test cases with different password lengths ..etc. -suresh -suresht