Mailing-List: contact derby-dev-help@db.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Derby Development" <derby-dev@db.apache.org>
Received-SPF: neutral (hermes.apache.org: local policy)
Message-ID: <4280F1A4.4050503@sbcglobal.net>
Date: Tue, 10 May 2005 10:38:44 -0700
From: Mike Matrigali <mikem_app@sbcglobal.net>
User-Agent: Mozilla Thunderbird 1.0 (Windows/20041206)
MIME-Version: 1.0
To: Derby Development <derby-dev@db.apache.org>
Subject: Re: [PATCH] Derby 237 Boot errror stack traces from store must not
 be lost
References: <427F9437.1070801@gmail.com>
In-Reply-To: <427F9437.1070801@gmail.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit

I committed this patch with svn  169501.

Sunitha Kambhampati wrote:
> http://issues.apache.org/jira/browse/DERBY-237?page=all
> 
> This patch fixes derby-237: Boot errors from store must not lose error 
> messages/stack traces in between.
> 
> Actually nested exceptions from the boot error were not lost but their 
> stack traces were not being written out into error stream which is why 
> the entire stack traces of exceptions was not printed out to derby.log
> 
> svn stat
> M      java\engine\org\apache\derby\impl\store\raw\log\LogToFile.java
> 
> 
> -- I tested it with a corrupted database (from derby 241) that resulted 
> in boot error and the stack traces are printed out ok in derby.log.
> -- I ran derbyall suite and all tests passed.
> 
> Please review it and if there are no comments, can a committer please 
> commit it.
> Thanks, Sunitha.
> 
> 
> ------------------------------------------------------------------------
> 
> Index: java/engine/org/apache/derby/impl/store/raw/log/LogToFile.java
> ===================================================================
> --- java/engine/org/apache/derby/impl/store/raw/log/LogToFile.java	(revision 168348)
> +++ java/engine/org/apache/derby/impl/store/raw/log/LogToFile.java	(working copy)
> @@ -3951,14 +3951,18 @@
>  		}
>  	}
>  
> +    /**
> +     * print stack trace from the Throwable including
> +     * its nested exceptions 
> +     * @param t trace starts from this error
> +     */
>  	private void printErrorStack(Throwable t)
>  	{
> -		Monitor.logMessage("-------------------------\n");
> -		t.printStackTrace(Monitor.getStream().getPrintWriter());
> -		Monitor.logMessage("-------------------------\n");
>  		ErrorStringBuilder esb = new ErrorStringBuilder(Monitor.getStream().getHeader());
>  		esb.stackTrace(t);
> -	}
> +        Monitor.logMessage(esb.get().toString());
> +        esb.reset();
> +    }
>  
>  
>  	/**