Return-Path: Delivered-To: apmail-db-derby-dev-archive@www.apache.org Received: (qmail 4530 invoked from network); 2 May 2005 20:39:58 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur.apache.org with SMTP; 2 May 2005 20:39:58 -0000 Received: (qmail 48384 invoked by uid 500); 2 May 2005 20:41:03 -0000 Delivered-To: apmail-db-derby-dev-archive@db.apache.org Received: (qmail 48171 invoked by uid 500); 2 May 2005 20:41:01 -0000 Mailing-List: contact derby-dev-help@db.apache.org; run by ezmlm Precedence: bulk list-help: list-unsubscribe: List-Post: List-Id: Reply-To: "Derby Development" Delivered-To: mailing list derby-dev@db.apache.org Received: (qmail 48075 invoked by uid 99); 2 May 2005 20:40:59 -0000 X-ASF-Spam-Status: No, hits=0.1 required=10.0 tests=FORGED_RCVD_HELO X-Spam-Check-By: apache.org Received-SPF: neutral (hermes.apache.org: local policy) Received: from adsl-209-233-18-245.dsl.snfc21.pacbell.net (HELO buttons.boynes.com) (209.233.18.245) by apache.org (qpsmtpd/0.28) with ESMTP; Mon, 02 May 2005 13:40:59 -0700 Received: from [192.168.17.112] (unknown [69.111.157.225]) by buttons.boynes.com (Postfix) with ESMTP id 544F113AFB for ; Mon, 2 May 2005 13:39:23 -0700 (PDT) Message-ID: <42768FDB.5020803@apache.org> Date: Mon, 02 May 2005 13:38:51 -0700 From: Jeremy Boynes User-Agent: Mozilla Thunderbird 0.8 (Windows/20040913) X-Accept-Language: en-us, en MIME-Version: 1.0 To: Derby Development Subject: DataSource class hierarchy in client X-Enigmail-Version: 0.86.1.0 X-Enigmail-Supports: pgp-inline, pgp-mime Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N The class hierarchy the client DataSources is: ClientBaseDataSource | +-- ClientDataSource | +-- ClientXADataSource | +-- ClientConnectionPoolDataSource The three standard interfaces DataSource, ConnectionPoolDataSource and XADataSource are not related to each other with different get??Connection methods that return different classes. I would like to propose refactoring this so that all three extend ClientBaseDataSource directly which will mean moving some of the properties from ClientDataSource down into the base class. Any thoughts on why this should not be done? -- Jeremy