db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew McIntyre <mcintyr...@gmail.com>
Subject Re: [PATCH] test harness sed.java & readme
Date Wed, 18 May 2005 20:21:44 GMT

On May 17, 2005, at 3:51 PM, Dag H. Wanvik wrote:

>>>>>> "MvL" == Myrna van Lunteren <m.v.lunteren@gmail.com> wrote:
>
> MvL> From looking at functionTests/harness/Sed.java after some trouble
> MvL> reported because of directory names, I noticed there was a lot of 
> old
> MvL> - let's call it: - stuff that wasn't needed anymore. So, this 
> patch
> MvL> contains a slightly cleaned up file.
>
> Would this also fix Derby-266? Or should that be closed and just
> called out in docs, too?

It appears from the description of Derby-266 that this patch would fix 
that issue.

Myrna, a couple things:

Reviewing this patch is rather difficult because it includes a lot of 
format changes mixed in with code that has been altered or removed. I'm 
not against reformatting, Sed.java is a particularly bad offender, but 
formatting changes should be in a separate diff.

Also, you didn't mention it in your original mail whether or not you 
ran derbyall and whether or not it passed. And, a JIRA should probably 
be filed for the fact that the test harness can't run in a path that 
contains spaces.

andrew


Mime
View raw message