db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew McIntyre <mcintyr...@gmail.com>
Subject Re: [PATCH] test harness sed.java & readme
Date Thu, 19 May 2005 06:10:37 GMT
On 5/18/05, Myrna van Lunteren <m.v.lunteren@gmail.com> wrote:
> To check, you want me to:
> 1. make a separate patch for Sed.java without any formatting.
> 2. another one for the readme.txt.

Actually, no, I've already reviewed the patch and it's fine. It just
took me a while, and it would have been easier if there were not so
many diffs that were just formatting related. I'll commit what you've
already submitted as-is.

> 3. log a bug for the spaces not working & fix that with the readme.txt patch

Yes, please. (or I will :-)  )

> And of course I ran all tests. Should've said so.

I suspected as much, but I wanted to make sure. No need to submit a
separate patch.

andrew

Mime
View raw message