db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Kathey Marsden <kmarsdende...@sbcglobal.net>
Subject Re: [jira] Commented: (DERBY-128) Network Server Gives NPE if SQLException has null arguments (e.g. for ERROR XBM0H)
Date Fri, 27 May 2005 11:54:29 GMT
Dyre.Tjeldvoll@Sun.COM wrote:

>Kathey Marsden <kmarsdenderby@sbcglobal.net> writes:
>
>[snip]
>
>  
>
>>Hi Dyre,
>>
>>Could you post a comment giving a summary of your change (e.g. Why you
>>changed from one newException call to another)
>>    
>>
>
>Hmm, sure I can do that. (Actually I didn't think it was necessary
>since you original description describes what the
>problem is, where it is, and implicitly how to fix it... :)
>(Will add a JIRA comment).
>
>  
>

Just in general it is good with the patch to post a brief summary of
what you changed, what tests you ran and the results, for instance, I
ran derbyall and <test> failed because of DERBY-XXX which is unrelated
to my changes.

These will be used by the committer in the checkin comments.   Really
nice if we can just cut and paste.  Otherwise we have to recreate the
comments from the bug history, test logs etc.

>>Can you add  a test for this?
>>    
>>
>
>As in a test for this particular problem (dirctory cannot be created),
>or a general test that checks at "environment" problems are detected
>and reported correctly...?
>
>I can try to make such a test, but it will take me a while since I'm
>not very familiar with the test harness...
>  
>
Always best to add to an existing test, perhaps in this case
NSInSameJVM.java could have a new method that tests this failure.  I
don't know if  File.setReadOnly would help here.



Mime
View raw message