db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Satheesh Bandaram <sathe...@Sourcery.Org>
Subject Re: Running derbyall before submitting patches
Date Thu, 26 May 2005 18:16:01 GMT
+10, if there is anything like that. :-)

I used to run 'derbyAll' for each patch I tried to commit, but not able
to do that anymore with so many patches being submitted these days. It
should be everyone's responsibility to run all tests before submitting a
patch. I will start asking for list of tests run before committing
patches, if not provided already.

Also, new people tend to miss updating multiple versions of master
files, if the test has different masters. (say for DerbyNet or
DerbyNetClient frameworks) It is also possible to have different master
files based on JVM being used or version.


Bernt M. Johnsen wrote:

>Hi all,
>The last week or two, derbyall has failed a lot the time. This makes
>it hard to verify that I haven't goofed up things when doing changes
>in the code (I run derbyall daily as a quality measure). To be able to
>work efficiently, many of us are dependent on a reliable test suite.
>So, I urge everyone who submits a patch to the Derby to run derbyall
>on at least one platform/vm and not only the "relevant" tests for the
>patch, even if you "know" that it should not be necessary. I think
>this would save us all a lot of work (even more time saved for the
>committers, I guess :-).
>I know this won't guarantee that derbyall runs correctly all the time,
>but the frequency of problems should at least go down.

View raw message