db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Satheesh Bandaram <sathe...@Sourcery.Org>
Subject Re: [PATCH] Timestamp Arithmetic
Date Tue, 24 May 2005 02:39:56 GMT
<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
<html>
<head>
  <meta content="text/html;charset=ISO-8859-1" http-equiv="Content-Type">
  <title></title>
</head>
<body bgcolor="#ffffff" text="#000000">
Submitted this patch. Thanks for applying all (well... most) of the
review comments. Couple of minor comments.<br>
<ol>
  <li>Derby doesn't support TINYINT datatype. Bind code in
TernaryOperatorNode is checking for this type.</li>
  <li>Method names haven't been changed to reflect Dan's suggestion. I
will let you two fight it out on that.<span class="moz-smiley-s1"><span>
:-) </span></span></li>
</ol>
Satheesh<br>
<br>
Sending&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; java\engine\org\apache\derby\iapi\reference\SQLState.java<br>
Sending&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;
java\engine\org\apache\derby\iapi\sql\compile\C_NodeTypes.java<br>
Sending&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;
java\engine\org\apache\derby\iapi\types\DateTimeDataValue.java<br>
Sending&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; java\engine\org\apache\derby\iapi\types\SQLDate.java<br>
Sending&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; java\engine\org\apache\derby\iapi\types\SQLTime.java<br>
Sending&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; java\engine\org\apache\derby\iapi\types\SQLTimestamp.java<br>
Sending&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;
java\engine\org\apache\derby\impl\sql\compile\NodeFactoryImpl.java<br>
Sending&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;
java\engine\org\apache\derby\impl\sql\compile\TernaryOperatorNode.java<br>
Sending&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;
java\engine\org\apache\derby\impl\sql\compile\sqlgrammar.jj<br>
Sending&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; java\engine\org\apache\derby\loc\messages_en.properties<br>
Adding&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;
java\testing\org\apache\derbyTesting\functionTests\master\timestampArith.out<br>
Sending&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;
java\testing\org\apache\derbyTesting\functionTests\suites\derbylang.runall<br>
Adding&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;
java\testing\org\apache\derbyTesting\functionTests\tests\lang\timestampArith.java<br>
Transmitting file data .............<br>
Committed revision 178061.<br>
<br>
Jack Klebanoff wrote:<br>
<blockquote cite="mid429285DF.4060209@sbcglobal.net" type="cite">Satheesh
Bandaram wrote:
  <br>
  <br>
  <blockquote type="cite">Jack, this patch submitted on Friday is
already not based on latest codeline... Shreyas's patch seems to have
modified couple of files you changed. Can you submit an updated patch,
that I will commit quickly, unless anyone else has comments on this
patch.
    <br>
    <br>
Satheesh
    <br>
    <br>
  </blockquote>
OK. I integrated my changes with the latest revisions. The resulting
patch is attached. It has passed the derbylang suite. Svn status is
  <br>
  <br>
M&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;
java/engine/org/apache/derby/impl/sql/compile/NodeFactoryImpl.java
  <br>
M&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;
java/engine/org/apache/derby/impl/sql/compile/TernaryOperatorNode.java
  <br>
M&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; java/engine/org/apache/derby/impl/sql/compile/sqlgrammar.jj
  <br>
M&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; java/engine/org/apache/derby/iapi/sql/compile/C_NodeTypes.java
  <br>
M&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; java/engine/org/apache/derby/iapi/types/DateTimeDataValue.java
  <br>
M&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; java/engine/org/apache/derby/iapi/types/SQLDate.java
  <br>
M&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; java/engine/org/apache/derby/iapi/types/SQLTime.java
  <br>
M&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; java/engine/org/apache/derby/iapi/types/SQLTimestamp.java
  <br>
M&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; java/engine/org/apache/derby/iapi/reference/SQLState.java
  <br>
M&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; java/engine/org/apache/derby/loc/messages_en.properties
  <br>
A&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;
java/testing/org/apache/derbyTesting/functionTests/tests/lang/timestampArith.java
  <br>
A&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;
java/testing/org/apache/derbyTesting/functionTests/master/timestampArith.out
  <br>
M&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;
java/testing/org/apache/derbyTesting/functionTests/suites/derbylang.runall
  <br>
  <br>
Jack Klebanoff
  <br>
  <pre wrap="">
  </pre>
</blockquote>
</body>
</html>


Mime
View raw message