db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Satheesh Bandaram <sathe...@Sourcery.Org>
Subject Re: Patch for DERBY-167 again*3
Date Fri, 20 May 2005 17:09:23 GMT
<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
<html>
<head>
  <meta content="text/html;charset=ISO-2022-JP"
 http-equiv="Content-Type">
  <title></title>
</head>
<body bgcolor="#ffffff" text="#000000">
This looks good to me(+1).&nbsp; If there are no further comments, I will
commit it.<br>
<br>
Since this is new feature, there may be a need for another +1 vote.<br>
<br>
Satheesh<br>
<br>
TomohitoNakayama wrote:<br>
<blockquote cite="mid002001c55c74$ea070ee0$2000a8c0@Arkat" type="cite">Hello.
  <br>
  <br>
I have made new patch.
  <br>
  <br>
What was changed was:
  <br>
  <br>
1 Modify comment in ColumnDefinitionNode.
  <br>
2 Remove assert which became surplus in ColumnDescriptor
  <br>
3 Add comment to complicated conditional expression in ResultSetNode
  <br>
4 Remove needless modification in ColumnDefintionNode. I found it when
trying to comment it.
  <br>
5 Modify how DefaultInfoImpl have attribute of DefaultValueAutoinc.
  <br>
6 Add final to DefaultInfoImpl.BITS_MASK_IS_DEFAULTVALUE_AUTOINC
  <br>
  <br>
Please review it again.
  <br>
  <br>
Best regards.
  <br>
  <br>
/*
  <br>
  <br>
&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; Tomohito Nakayama
  <br>
&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; <a class="moz-txt-link-abbreviated"
href="mailto:tomonaka@basil.ocn.ne.jp">tomonaka@basil.ocn.ne.jp</a>
  <br>
&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; <a class="moz-txt-link-abbreviated"
href="mailto:tomohito@rose.zero.ad.jp">tomohito@rose.zero.ad.jp</a>
  <br>
  <br>
&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; Naka
  <br>
&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; <a class="moz-txt-link-freetext"
href="http://www5.ocn.ne.jp/~tomohito/TopPage.html">http://www5.ocn.ne.jp/~tomohito/TopPage.html</a>
  <br>
  <br>
*/
  <pre wrap="">
<hr size="4" width="90%">
No virus found in this outgoing message.
Checked by AVG Anti-Virus.
Version: 7.0.322 / Virus Database: 266.11.12 - Release Date: 2005/05/17
  </pre>
</blockquote>
</body>
</html>


Mime
View raw message