db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From David Van Couvering <da...@vancouvering.com>
Subject Re: [jira] Commented: (DERBY-243) connection toString should uniquely identify the connection
Date Thu, 19 May 2005 15:55:10 GMT


Kathey Marsden (JIRA) wrote:

>      [ http://issues.apache.org/jira/browse/DERBY-243?page=comments#action_65735 ]
>      
> Kathey Marsden commented on DERBY-243:
> --------------------------------------
> 
> I performed only a very rough review of this diff.  I am hoping someone else can do a
more detailed review once the following issues have been resolved.
> 
> 1) I tend to think that it is confusing to have a separate UUID for the client connection.
 In a client server environment, each connection has two separate UUID's, which could get
confusing.  Especially since the connection id semantics change when dealing with client.
 There is an existing Derby entry Derby-293 to correlate the client and server connections.
Might it be good to defer the client part of this work until that is considered?

If I understand you right, you are thinking that the toString() of the 
client connection has a direct correlation to the toString() of the 
associated embedded connection, or even matches the toString() of the 
embedded connection.  I can definitely see how that would have some value.

But, wouldn't that require some message exchange during login to pass 
the embedded connection information back to the client?  I'm very new to 
DRDA and am not sure how flexible the protocol is to this sort of thing.

At any rate, perhaps you are right that this should be deferred to 
DERBY-293.  If there are no objections, I can back out the client 
changes as part of this patch.

> 
> 2) I think it would be good to document the connection id semantics in the Jira entry
and the code.

OK, I can do that.

David

> 
> 
> 
> 
>>connection toString should uniquely identify the connection
>>-----------------------------------------------------------
>>
>>         Key: DERBY-243
>>         URL: http://issues.apache.org/jira/browse/DERBY-243
>>     Project: Derby
>>        Type: Improvement
>>  Components: JDBC
>>    Reporter: Kathey Marsden
>>    Assignee: David Van Couvering
>>    Priority: Trivial
>>     Fix For: 10.0.2.0, 10.0.2.1, 10.0.2.2, 10.1.0.0
>> Attachments: DERBY-243.diff
>>
>>The toString() on the Derby connection doesn't print 
>>unique information.
>>for example  System.out.println(conn) prints:
>>EmbedConnection  in the case of derby embedded
>>It would be great if the toString() method for connections could be used to differentiate
one connection from another.
> 
> 


Mime
View raw message