db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Kathey Marsden <kmarsdende...@sbcglobal.net>
Subject Re: [PATCH] (DERBY-205) Rename org.apache.derby.impl.drda.DB2jServerImpl to NetworkServerControlImpl
Date Wed, 18 May 2005 04:58:49 GMT
Dag H. Wanvik wrote:
[snip]

>Anyway, the name deduced for the log by NetworkServerControlImpl ends
>up in NetworkServerControlImpl's private field errorLogLocation, which
>in turn is used *only* (as far as i can tell) by DRDAConnThread,
>through getErrorLogLocation(), to make exception strings for the
>client.
>
>  
>
Yes  it is only used to reprort a log location to the client in the
message tokens for a fatal errors where the
client won't be able to call the  stored procedure to retrieve message
text,

> I am considering saving the name in a field
>in BasicHeaderPrintWriter and extend the HeaderPrintWriter interface
>to allow NetworkServerControlImpl to access it:
>
>	public void blockingStart(PrintWriter consoleWriter)
>		throws Exception
>	{
>		startNetworkServer();
>		setLogWriter(consoleWriter);
>***>		errorLogLocation = Monitor.getStream().getName();
>		cloudscapeLogWriter = Monitor.getStream().getPrintWriter();
>
>thus getting rid of the offending code in
>NetworkServerControlImpl.getPropertyInfo().  This would lead to
>errorLogLocation being set *later* (not as now, by the constructor of
>NetworkServerControlImpl), but it looks like it will still be set in
>time (i.e. before any connections are opened).
>
>What do you think? 
>  
>

I can't say I know all the implications, but I think that sounds like a
good plan.
Thanks for cleaning this up.

Kathey



Mime
View raw message