db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Satheesh Bandaram <sathe...@Sourcery.Org>
Subject Re: Patch again again for DERBY-167.
Date Wed, 18 May 2005 01:00:54 GMT
<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
<html>
<head>
  <meta content="text/html;charset=ISO-8859-1" http-equiv="Content-Type">
  <title></title>
</head>
<body bgcolor="#ffffff" text="#000000">
Thanks for applying review comments. Overall, the patch looks good.<br>
<br>
Some minor comments:<br>
<blockquote>
  <ol>
    <li>ColumnDefinitionNode: I would like to see following comments be
more descriptive. Initially I thought these refer to another method,
but that is not the case. </li>
    <ol>
      <li>+&nbsp;&nbsp;&nbsp; &nbsp;&nbsp;&nbsp; //validateDefaultOfAutoInc<br>
+&nbsp;&nbsp;&nbsp; &nbsp;&nbsp;&nbsp; //validateDefaultOfDefault<br>
      </li>
    </ol>
    <li>ColumnDescriptor.java: Is there an extra assert for autoincInc
being non-zero at line: 156? (Second constructor). Also 'static' is not
needed for assertAutoinc() method.</li>
  </ol>
</blockquote>
Please apply Army's and my comments. I also invite others to review the
patch, since I will be looking to commit this one soon, after getting
an updated patch.<span class="moz-smiley-s1"><span> :-) </span></span><br>
<br>
Satheesh<br>
<br>
TomohitoNakayama wrote:
<blockquote cite="mid003701c5588c$1fa267d0$2000a8c0@Arkat" type="cite">Hello.
  <br>
  <br>
I send new patch for DERBY-167 , which is attached to this mail.
  <br>
Please review it.
  <br>
  <br>
Best regards.
  <br>
  <br>
/*
  <br>
  <br>
&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; Tomohito Nakayama
  <br>
&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; <a class="moz-txt-link-abbreviated"
href="mailto:tomonaka@basil.ocn.ne.jp">tomonaka@basil.ocn.ne.jp</a>
  <br>
&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; <a class="moz-txt-link-abbreviated"
href="mailto:tomohito@rose.zero.ad.jp">tomohito@rose.zero.ad.jp</a>
  <br>
  <br>
&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; Naka
  <br>
&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; <a class="moz-txt-link-freetext"
href="http://www5.ocn.ne.jp/~tomohito/TopPage.html">http://www5.ocn.ne.jp/~tomohito/TopPage.html</a>
  <br>
  <br>
*/
  <br>
----- Original Message ----- From: "Army" <a class="moz-txt-link-rfc2396E" href="mailto:qozinx@sbcglobal.net">&lt;qozinx@sbcglobal.net&gt;</a>
  <br>
To: "Derby Development" <a class="moz-txt-link-rfc2396E" href="mailto:derby-dev@db.apache.org">&lt;derby-dev@db.apache.org&gt;</a>
  <br>
Sent: Saturday, May 14, 2005 9:13 AM
  <br>
Subject: Re: Patch again for DERBY-167.
  <br>
  <br>
  <br>
  <blockquote type="cite">TomohitoNakayama wrote:
    <br>
    <blockquote type="cite">Hello.
      <br>
      <br>
I send new patch for DERBY-167.
      <br>
Please review it again.
      <br>
    </blockquote>
    <br>
I tried to apply this patch to my local codeline (which I just updated)
so
    <br>
that I could review it more closely, but the patch fails to apply in
    <br>
several places.
    <br>
    <br>
I know it's annoying, but could you perhaps "svn update" your codeline
and
    <br>
then re-create the patch based on the latest files?
    <br>
    <br>
If I can get the patch to apply, it makes it easier to review the code.
    <br>
Also, I can then run the new/updated tests and verify that everything
    <br>
works as intended...
    <br>
    <br>
Thanks,
    <br>
Army
    <br>
    <br>
    <br>
    <br>
    <br>
--&nbsp;<br>
No virus found in this incoming message.
    <br>
Checked by AVG Anti-Virus.
    <br>
Version: 7.0.308 / Virus Database: 266.11.10 - Release Date: 2005/05/13
    <br>
    <br>
    <br>
  </blockquote>
  <pre wrap="">
<hr size="4" width="90%">
No virus found in this outgoing message.
Checked by AVG Anti-Virus.
Version: 7.0.308 / Virus Database: 266.11.10 - Release Date: 2005/05/13
  </pre>
</blockquote>
</body>
</html>


Mime
View raw message