db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jack Klebanoff <klebanoff-de...@sbcglobal.net>
Subject Re: [PATCH] Timestamp Arithmetic
Date Mon, 16 May 2005 15:56:55 GMT
Daniel John Debrunner wrote:

>Jack, could you provide some reasoning why your new
>TimestampArithmeticFnNode node doesn't fall into the existing heirachy
>for arithmetic operators, namely BinaryArithmeticOperatorNode?
>I would like to see Derby consolidate more compilation nodes, rather
>than create new ones. New nodes increase the static and runtime
>footprint, but don't usually add much value if the logic could be in an
>exisiting node.
>>+public class TimestampArithmeticFnNode extends ValueNode
The timestamp escape functions are ternary functions, not binary 
operators. I looked at trying to consolidate them with the binary or 
unary operator nodes, but there was not that much commonality. It was an 
awkard fit.


View raw message