db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Kathey Marsden <kmarsdende...@sbcglobal.net>
Subject Re: [PATCH] (DERBY-205) Rename org.apache.derby.impl.drda.DB2jServerImpl to NetworkServerControlImpl
Date Wed, 11 May 2005 20:40:19 GMT
Dag H. Wanvik wrote:

>I have made a proposed patch for Derby-205. 
>I ran the regression test (derbyall) with no errors, after
>battling with Derby-266 for a bit :)
>Enclosed is the svn stat and diff. Can somebody please review this
>with a watchful eye? It's my first patch :)

Hi Dag,
Your patch looks good and passes all  network server tests for me. I
went ahead and committed the change.  You can submit the property
cleanup as a follow on patch.  This way we keep the rename separate.

Thanks for the patch!  That  name was really bugging me.

If you are interested in housecleaning tasks like this as a way to tour
the code and learn about Derby in a low risk way,  I would highly
recommend Derby 204.

Please consider submitting an  Individual Contributor License Agreement
(CLA), if you plan on submitting additional patches. <icla.txt>
See the link at  http://www.apache.org/licenses/#clas


View raw message