db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Satheesh Bandaram <sathe...@Sourcery.Org>
Subject Re: [jira] Created: (DERBY-242) DatabaseMetaData.supportsGetGeneratedKeys needs to return FALSE, since Derby only has limited support.
Date Wed, 04 May 2005 19:55:23 GMT
<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
<html>
<head>
  <meta content="text/html;charset=ISO-8859-1" http-equiv="Content-Type">
  <title></title>
</head>
<body bgcolor="#ffffff" text="#000000">
Committed this patch. I also searched for all references to
supportsGetGeneratedKeys() in the test &amp; master files. This was the
only reference. Lance, can you RESOLVE the Jira entry and then CLOSE
it, please?<br>
<br>
Satheesh<br>
<br>
------------------------------------------------------------------------<br>
r168176 | bandaram | 2005-05-04 12:50:21 -0700 (Wed, 04 May 2005) | 3
lines<br>
<br>
Derby-242: Make DatabaseMetadata.supportsMultipleOpenResults() return
FALSE.<br>
<br>
Submitted by Lance Anderson. (<a class="moz-txt-link-abbreviated" href="mailto:Lance.Andersen@Sun.COM">Lance.Andersen@Sun.COM</a>)<br>
------------------------------------------------------------------------<br>
<br>
Lance J. Andersen wrote:
<blockquote cite="mid42792570.5090407@sun.com" type="cite">
  <meta content="text/html;charset=ISO-8859-1" http-equiv="Content-Type">
  <title></title>
Hi Mamta,<br>
  <br>
The only test I saw&nbsp; and ran was DBMetaDataJdbc30 when I searched the
codeline. (You saw my notes on my other failures in jdk14 test run, but
this one passed)<br>
  <br>
I also noticed that the other drivers were already set to false.<br>
  <br>
Regards<br>
Lance<br>
  <br>
Mamta Satoor wrote:<br>
  <blockquote cite="midd9619e4a0505041232488fb1d9@mail.gmail.com"
 type="cite">
    <pre wrap="">Hi Lance,

I looked at the review package and it looks good. Good comments in the
EmbedDatabaseMetaData.java. Just wondered if you ran the existing
tests to make sure nothing got affected by the change.

Mamta

On 5/4/05, Lance J. Andersen <a class="moz-txt-link-rfc2396E"
 href="mailto:Lance.Andersen@sun.com">&lt;Lance.Andersen@sun.com&gt;</a>
wrote:
  </pre>
    <blockquote type="cite">
      <pre wrap="">Oh, I forgot to mention that i validated that the dbMetaDataJdbc30
in jdk14
passed.



Lance Andersen wrote:

Attached is the patch. 

Regards 
Lance 

Mamta Satoor wrote: 
Hi Lance, 

Thanks for taking it. Yes, it is for Embedded Driver. 

Mamta 

On 4/29/05, Lance J. Andersen <a class="moz-txt-link-rfc2396E"
 href="mailto:Lance.Andersen@sun.com">&lt;Lance.Andersen@sun.com&gt;</a>
wrote: 

I take it this is with the Embedded Driver as it looks like the code for the
new Client Driver is returning false. 

I can take this if no one else wants it. 


Mamta Satoor wrote: 
Hi, 


I think this is a very easy bug to fix. So, if someone is looking 

for 

an opportunity to start with a simple bug, this will be a good 

one. 


Mamta 

On 4/26/05, Satheesh Bandaram (JIRA) <a class="moz-txt-link-rfc2396E"
 href="mailto:derby-dev@db.apache.org">&lt;derby-dev@db.apache.org&gt;</a>


wrote: 

  

DatabaseMetaData.supportsGetGeneratedKeys needs to return 
FALSE, since Derby only has limited 
support. 

------------------------------------------------------------------------------------------------------


Key: DERBY-242 

 URL: 

<a class="moz-txt-link-freetext"
 href="http://issues.apache.org/jira/browse/DERBY-242">http://issues.apache.org/jira/browse/DERBY-242</a>


 Project: 

Derby 

 Type: Bug 
 Components: JDBC 
 Versions: 10.0.2.0 
Environment: ALL 

Reporter: Satheesh Bandaram 

Assigned to: Satheesh Bandaram 
 Fix For: 

10.1.0.0 


Derby only has partial support for retrieving generated 

values. 

Because of this, it is desirable to 

make 

DatabaseMetaData.supportsGetGeneratedKeys return 

FALSE. One 

of the restrictions include Jira entry Derby-201. Till this 

is 

fixed, we should change derby to return FALSE for this. 

This would also 

match Derby client behavior. 


-- 
This message is automatically generated by 

JIRA. 

- 
If you think it was sent incorrectly contact one of the 

administrators: 
<a class="moz-txt-link-freetext"
 href="http://issues.apache.org/jira/secure/Administrators.jspa">http://issues.apache.org/jira/secure/Administrators.jspa</a>


- 
For 

more information on JIRA, see: 
<a class="moz-txt-link-freetext"
 href="http://www.atlassian.com/software/jira">http://www.atlassian.com/software/jira</a>



  

  



________________________________

    </pre>
    </blockquote>
    <pre wrap=""><!---->Index:
  </pre>
    <blockquote type="cite">
      <pre wrap="">java/engine/org/apache/derby/impl/jdbc/EmbedDatabaseMetaData.java
    </pre>
    </blockquote>
    <pre wrap=""><!---->===================================================================
---
  </pre>
    <blockquote type="cite">
      <pre wrap="">java/engine/org/apache/derby/impl/jdbc/EmbedDatabaseMetaData.java
(revision 168122)
    </pre>
    </blockquote>
    <pre wrap=""><!---->+++
  </pre>
    <blockquote type="cite">
      <pre wrap="">java/engine/org/apache/derby/impl/jdbc/EmbedDatabaseMetaData.java
(working copy)
    </pre>
    </blockquote>
    <pre wrap=""><!---->@@ -2880,7 +2880,13 @@
 */
 public boolean
  </pre>
    <blockquote type="cite">
      <pre wrap="">supportsGetGeneratedKeys()
    </pre>
    </blockquote>
    <pre wrap=""><!----> {
- return true;
+ /*
+ * Currently reverting
  </pre>
    <blockquote type="cite">
      <pre wrap="">the returned value to false until there 
    </pre>
    </blockquote>
    <pre wrap=""><!---->+ * is more support for
  </pre>
    <blockquote type="cite">
      <pre wrap="">autogenerated keys in Derby.
    </pre>
    </blockquote>
    <pre wrap=""><!---->+ * (such as support for specifying the
  </pre>
    <blockquote type="cite">
      <pre wrap="">returned columns for
    </pre>
    </blockquote>
    <pre wrap=""><!---->+ * the autogenerated key)
+ */
+ return false;
 }
 
  </pre>
    <blockquote type="cite">
      <pre wrap="">/**
    </pre>
    </blockquote>
    <pre wrap=""><!---->Index:
  </pre>
    <blockquote type="cite">
      <pre wrap="">java/testing/org/apache/derbyTesting/functionTests/master/dbMetaDataJdbc30.out
    </pre>
    </blockquote>
    <pre wrap=""><!---->===================================================================
---
  </pre>
    <blockquote type="cite">
      <pre wrap="">java/testing/org/apache/derbyTesting/functionTests/master/dbMetaDataJdbc30.out
(revision 168122)
    </pre>
    </blockquote>
    <pre wrap=""><!---->+++
  </pre>
    <blockquote type="cite">
      <pre wrap="">java/testing/org/apache/derbyTesting/functionTests/master/dbMetaDataJdbc30.out
(working copy)
    </pre>
    </blockquote>
    <pre wrap=""><!---->@@ -4,7 +4,7 @@
 supportsSavepoints() : true
  </pre>
    <blockquote type="cite">
      <pre wrap="">supportsNamedParameters() : false
    </pre>
    </blockquote>
    <pre wrap=""><!----> supportsMultipleOpenResults() :
  </pre>
    <blockquote type="cite">
      <pre wrap="">true
    </pre>
    </blockquote>
    <pre wrap=""><!---->-supportsGetGeneratedKeys() : true
+supportsGetGeneratedKeys() : false
  </pre>
    <blockquote type="cite">
      <pre wrap="">supportsResultSetHoldability(HOLD_CURSORS_OVER_COMMIT) :
true
    </pre>
    </blockquote>
    <pre wrap=""><!----> supportsResultSetHoldability(CLOSE_CURSORS_AT_COMMIT)
  </pre>
    <blockquote type="cite">
      <pre wrap="">: true
    </pre>
    </blockquote>
    <pre wrap=""><!----> getJDBCMajorVersion() : 3
 
&gt;
  </pre>
  </blockquote>
</blockquote>
</body>
</html>


Mime
View raw message