db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dyre Tjeldvoll (JIRA)" <derby-...@db.apache.org>
Subject [jira] Created: (DERBY-330) Many files do not have correct svn-properties
Date Tue, 31 May 2005 12:48:56 GMT
Many files do not have correct svn-properties
---------------------------------------------

         Key: DERBY-330
         URL: http://issues.apache.org/jira/browse/DERBY-330
     Project: Derby
        Type: Bug
  Components: Build tools  
 Environment: Any
    Reporter: Dyre Tjeldvoll
    Priority: Trivial


There are two problems with svn properties in Derby:

1) A number of non-binary files do not have the svn:eol-style=native property set. Some of
these currently has CRLF (Windows-style) line terminators, 
Example:
dt136804@atum10~/local/DERBY/d_rby-138$ file ./plugins/eclipse/org.apache.derby.ui/src/org/apache/derby/ui/popup/actions/RemoveDerbyNature.java
./plugins/eclipse/org.apache.derby.ui/src/org/apache/derby/ui/popup/actions/RemoveDerbyNature.java:
ASCII C program text, with CRLF line terminators
dt136804@atum10~/local/DERBY/d_rby-138$ svn proplist -v ./plugins/eclipse/org.apache.derby.ui/src/org/apache/derby/ui/popup/actions/RemoveDerbyNature.java


whereas others have LF(Unix-style). 
Example:
dt136804@atum10~/local/DERBY/d_rby-138$ file ./plugins/eclipse/org.apache.derby.ui/src/org/apache/derby/ui/actions/SysInfoAction.java
./plugins/eclipse/org.apache.derby.ui/src/org/apache/derby/ui/actions/SysInfoAction.java:
ASCII C program text
dt136804@atum10~/local/DERBY/d_rby-138$ svn proplist -v ./plugins/eclipse/org.apache.derby.ui/src/org/apache/derby/ui/actions/SysInfoAction.java

Some of the files that don't have this property do instead have a property called "snv:eol-style".
I'm guessing this is a typo.
Example:
dt136804@atum10~/local/DERBY/d_rby-138$ svn proplist -v java/testing/org/apache/derbyTesting/unitTests/crypto/T_CipherOFB.java
Properties on 'java/testing/org/apache/derbyTesting/unitTests/crypto/T_CipherOFB.java':
  snv:eol-style : native


2) A seemingly arbitrary collection of files have the svn:executable property set. To my knowledge,
the only files in the Derby respository that should have this property are the *.ksh and perhaps
the *.bat scripts, (I don't know if Windows cares about this property when the file has the
.bat suffix). Currently none of the *.ksh scripts have this property, but a number of java
source files (not all) have it. (If there is some reason to have this property on other files,
it should at least be done consistently throughout the repository).

Example:
dt136804@atum10~/local/DERBY/d_rby-138$ svn proplist -v java/drda/org/apache/derby/drda/NetworkServerControl.java
Properties on 'java/drda/org/apache/derby/drda/NetworkServerControl.java':
  svn:executable :
  svn:eol-style : native

dt136804@atum10~/local/DERBY/d_rby-138$ svn proplist -v java/testing/org/apache/derbyTesting/unitTests/crypto/T_CipherOFB.java
Properties on 'java/testing/org/apache/derbyTesting/unitTests/crypto/T_CipherOFB.java':
  snv:eol-style : native

If I understand correctly it is not possible to create a patchfile that contains property
changes, so I guess a committer will have to do this. I'm willing to create a script file
containing all the svn commands that must be run, as a "pseudo patch".

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


Mime
View raw message