db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Daniel John Debrunner <...@debrunners.com>
Subject Re: [PATCH] upgrade fix related to checksum support for transaction log to recognize out of order log writes during recovery (Derby-96)
Date Mon, 25 Apr 2005 20:39:19 GMT
Suresh Thalamati wrote:

> Attached is the  new  patch  with the suggested changes to make
> softupgrade correctly with the  transaction log
> checksum feature in 10.1 Added  checkVersion() method  to log factory it
> self,  becuase that is where
> the  version numbers are read  from  from the log control file , but did
> not export the call it to  the
> rawstore factory  as it is not needed now.  (This can be done easlily
> when there is a  need for upgrade
> checks  in the other store modules..)

+	boolean checkVersion(int requiredMajorVersion, int requiredMinorVersion)
+	{
+		if(onDiskMajorVersion >= requiredMajorVersion &&
+		   onDiskMinorVersion >= requiredMinorVersion)
+			return true;
+		else
+			return false;
+	}

Won't this method return the incorrect result if the on disk is 11.0
(major.minor) and the required version is 10.1? Ie. with this
combination the method should return true.


View raw message