db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Shreyas Kaushik <Shreyas.Kaus...@Sun.COM>
Subject Re: [jira] Commented: (DERBY-156) Delete with alias on column fails
Date Thu, 07 Apr 2005 14:40:52 GMT
Please see inline.

Kathey Marsden wrote:

>Shreyas Kaushik wrote:
>
>  
>
>>Can somebody reply on this?
>>
>>~ Shreyas
>>
>>Shreyas Kaushik wrote:
>>
>>    
>>
>>>Did any1 have a chance to look at this?
>>>
>>>~ Shreyas
>>>
>>>Shreyas Kaushik wrote:
>>>
>>>      
>>>
>>>>I did some changes to sqlgrammar.jj file to make a fix for this.
>>>>With the patch , the following cases are taken care :
>>>>1) delete from <tablename> <correlationName> where
>>>><correlatioName>.<columnName> = <value>
>>>>2) delete from <tablename> AS <correlationName> where
>>>><correlatioName>.<columnName> = <value>
>>>>
>>>>But when I ran derbyall I had a couple of failures.
>>>>I am attaching the test failure diffs here as well.
>>>>
>>>>Please comment.
>>>>
>>>>~ Shreyas
>>>>        
>>>>
>
>What did you find in anlalyzing your test failures?   I have not looked
>at your diffs specifically, but one thing I have found helpful is that
>often if there is a trace it is in the .tmp file, and has been filtered
>out of  the .out file.   
>
No, nothing has been filtered out.

>Take a  look at the failures and try to
>determine how they might relate to your changes and let us know if you
>have some more specific questions,  what is failing how you think it may
>or may not be related to your change.
>  
>
w.r.t floattypes I don't see how my changes could have made any impact 
there.
But the tests in refActions1 that have failed were earlier failing as 
there was no correlation name handling for
delete statements. These were giving a different error as the diffs show.
But now with the correlation name handling fixed ( hopefully ;-) )  I 
don't know whether the queries that are
erroring out are correct ? It could be that I might have also missed 
something. I want people here to have a look at it
so that they might spot something that I may have missed.

~ Shreyas

>Kathey
>
>
>
>
>  
>

Mime
View raw message