db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Rajesh Kartha <kar...@Source-Zone.Org>
Subject Re: [jira] Created: (DERBY-153) Bad Eclipse plugin version specification
Date Sun, 20 Mar 2005 05:47:34 GMT
Just following up...

Are there any comments/suggestion. If everybody agrees, can this patch 
be applied.

We will have to refresh the Apache Derby Core Plug-in  file on the 
download page though, so it can work
with the Eclipse3.1M5a  and also close the Defect 153.

-Rajesh

Rajesh Kartha wrote:

>
> The Derby Core plug-in for Eclipse used to work just fine in all the 
> Eclipse 3.x verisons of recent times (Eclipse 3.1M4). But
> with the latest Eclipse 3.1M5a release, using the Derby build number 
> as a part of the version information in the Derby Core
> plug-in's plugin.xml creates issues while loading. To fix this I 
> suggest we change the version inside plugin.xml  to show only
> the MAJOR.Minor.interim.point of the Derby build.
>
> For example:
> The old way of  10.1.0.0 (124830) will become 10.1.0.0
>
> I have changed the 
> org.apache.derbyBuild.eclipse.DerbyEclipsePlugin.java file to reflect 
> the above. Please find attached
> the diff file.
> If everybody agrees to this, can  this patch be applied (main and 10.0 
> codelines) to close the defect 153. We will also have to
> refresh the plug-ins, already available at the Apache Derby download 
> site, with the above change.
>
> Comments/Suggestions, please feel free to send them to the list.
>
> Regards,
> Rajesh
>
>
>
> Rajesh Kartha wrote:
>
>> Jörg von Frantzius (JIRA) wrote:
>>
>>> Bad Eclipse plugin version specification
>>> ----------------------------------------
>>>
>>>         Key: DERBY-153
>>>         URL: http://issues.apache.org/jira/browse/DERBY-153
>>>     Project: Derby
>>>        Type: Bug
>>>    Versions: 10.1.0.0    Environment: Eclipse 3.1 M5 (probably 
>>> problematic also with earlier versions)
>>>    Reporter: Jörg von Frantzius
>>>
>>>
>>> In the plugin.xml of the Derby Eclipse plugin, the version 
>>> specification reads "10.1.0.0 (124830)", which Eclipse complains 
>>> about as being illegal. In consequence, the plugin is not loaded.
>>>
>>> The Eclipse docs have the following to say about the version 
>>> specification: "Plug-in version format is 
>>> major.minor.service.qualifier".
>>>
>>> Stripping the "(1234830)", whatever that is anyway, solves the problem.
>>>
>>>  
>>>
>> Hello,
>> I will look into that. The big number (1234830) is the Derby build 
>> number. The Derby plugin  version worked fine on Eclipse 3.0 and 
>> hence we decided to add that in there, but looks like things have 
>> changed again in Eclipse 3.1 M5.
>>
>> I will post my changes to the dev-list  soon after testing the newer 
>> one.
>>
>> Regards,
>> Rajesh
>>
>>
>>
>
>------------------------------------------------------------------------
>
>Index: java/build/org/apache/derbyBuild/eclipse/DerbyEclipsePlugin.java
>===================================================================
>--- java/build/org/apache/derbyBuild/eclipse/DerbyEclipsePlugin.java	(revision 156723)
>+++ java/build/org/apache/derbyBuild/eclipse/DerbyEclipsePlugin.java	(working copy)
>@@ -149,10 +149,13 @@
> 		version=prop.getProperty(PropertyNames.PRODUCT_MAJOR_VERSION)+"."+prop.getProperty(PropertyNames.PRODUCT_MINOR_VERSION)+"."+maint/MAINT_DIV;
> 		tmpProp.put(PLUGIN_VERSION,version);
> 
>-		//initially thought of using
>-		//version+="."+maint%MAINT_DIV+"_v"+prop.getProperty(PropertyNames.PRODUCT_BUILD_NUMBER);
>-		version+="."+maint%MAINT_DIV+" ("+prop.getProperty(PropertyNames.PRODUCT_BUILD_NUMBER)+")";
>-		tmpProp.put(PLUGIN_VERSION_BUILD_NUMBER,version);
>+		//With Eclipse 3.1M5a release, adding '(PRODUCT_BUILD_NUMBER)' to the 'version' info
in
>+		//the plugin.xml creates some issues while loading. It has been removed and only the
>+		//MAJOR.Minor.interim.point has been added to the plugin.xml.
>+		//The actual Derby build version can be obtained using the 'sysinfo' tool.
>+		
>+		version+="."+maint%MAINT_DIV;
>+		tmpProp.put(PLUGIN_VERSION_BUILD_NUMBER,version+" ("+prop.getProperty(PropertyNames.PRODUCT_BUILD_NUMBER)+")");
> 
> 		//add info to plugin.xml strings
> 		part_1+=version+"\"";
>  
>



Mime
View raw message