db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jean T. Anderson" <...@bristowhill.com>
Subject How to prepare patches
Date Tue, 08 Mar 2005 18:33:05 GMT
Myrna posted steps for preparing a patch :
http://mail-archives.eu.apache.org/mod_mbox/db-derby-dev/200503.mbox/%3c4224C177.6050708@Golux.Com%3e

I'd like to add these instructions to : 
http://incubator.apache.org/derby/derby_comm.html

Below are her instructions and a followup suggestion from Jeremy. Are 
there any other suggestions?

thanks,

  -jean

Myrna's instructions:

> To prepare a patch, you first use svn to add your file to the
> appropriate spot. Best to first sync up...
>      - cd <my_derby_loc>/trunk
>      - svn update
>      - svn add java/engine/impl/yadiyadi/xyz.java
>      - svn propset svn:eol-style native java/engine/impl/yadiyadi/xyz.java
>      - then you should run the tests (depending on your change, but to
> be safe, deryball)
>            - ant all
>            - set your CLASSPATH env var to include the trunk/classes dir
>            - cd <a temp/test dir>
>            -  java
> org.apache.derbyTesting.functionTests.harness.RunSuite derbyall
>         after you've resolved any test failures (eg. updated relevant
> ../functionTests/master/*.out files)
>         you can make the patch.
>      - svn diff > xyz.diff
> Then, mail the xyz.diff to the list. Indicate which tests you've run.


Jeremy's suggestion:

>>Then, mail the xyz.diff to the list. Indicate which tests you've run.
>>
> 
> Or attach it to the Jira issue. That also aids tracking and avoids the email issues.


Mime
View raw message