db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "TomohitoNakayama" <tomon...@basil.ocn.ne.jp>
Subject Re: [Patch] Re: About improvement of DERBY-134
Date Wed, 30 Mar 2005 10:22:47 GMT
Hello.

Thanks.
I see. I re-sended patch via JIRA.

I will send ICLA in days.
Because it is a bit substantial , I need time ...

Best regards.

/*

         Tomohito Nakayama
         tomoihto@rose.zero.ad.jp
         tomonaka@basil.ocn.ne.jp

         Naka
         http://www5.ocn.ne.jp/~tomohito/TopPage.html

*/
----- Original Message ----- 
From: "Satheesh Bandaram" <satheesh@Sourcery.Org>
To: "Derby Development" <derby-dev@db.apache.org>
Sent: Wednesday, March 30, 2005 3:43 AM
Subject: Re: [Patch] Re: About improvement of DERBY-134


>I will work on committing this patch. Since you are working on an
> improvement, would you mind submitting this patch through Jira? Use
> AttachFile option and you also need to select "Grant ASF license to
> include in ASF works"  option. (URL:
> http://issues.apache.org/jira/secure/AttachFile!default.jspa?id=29790)
> This would help committers in accepting the patch.
> 
> Also, you might want to consider signing ICLA with Apache.
> (http://www.apache.org/licenses/icla.txt) This will help process your
> contributions faster. This is also a requirement to becoming a committer
> at a future time.
> 
> Satheesh
> 
> TomohitoNakayama wrote:
> 
>> Waiting 1 day and no error was found.
>> Can I ask committers to commit this patch ?
>>
>> Or I should commit it by myself ?
>>
>> Best regards.
>>
>> /*
>>
>>         Tomohito Nakayama
>>         tomoihto@rose.zero.ad.jp
>>         tomonaka@basil.ocn.ne.jp
>>
>>         Naka
>>         http://www5.ocn.ne.jp/~tomohito/TopPage.html
>>
>> */
>> ----- Original Message ----- From: "Jack Klebanoff"
>> <klebanoff-derby@sbcglobal.net>
>> To: "Derby Development" <derby-dev@db.apache.org>
>> Sent: Tuesday, March 29, 2005 4:31 AM
>> Subject: Re: [Patch] Re: About improvement of DERBY-134
>>
>>
>>> TomohitoNakayama wrote:
>>>
>>>> Hello.
>>>>
>>>> I have added some test to orderby.sql (and correspond result to
>>>> orderby.out) ,
>>>> which was suggested by Jack Klebanoff.
>>>>
>>>> And I have executed derbylang test and coulud not found error exept
>>>> for lang/floattypes.sql.
>>>> I think this error is not caused by my patch.
>>>>
>>>> derbylang_report.txt is attached to this mail.
>>>>
>>>> Please check this patch from a point of other person's view.
>>>>
>>>> best regards.
>>>>
>>>> /*
>>>>
>>>>         Tomohito Nakayama
>>>>         tomoihto@rose.zero.ad.jp
>>>>         tomonaka@basil.ocn.ne.jp
>>>>
>>>>         Naka
>>>>         http://www5.ocn.ne.jp/~tomohito/TopPage.html
>>>>
>>>> */
>>>
>>>
>>> The latest patch looks good to me. I looked at the changes, applied
>>> the patch to recently updated Derby source, and successfully ran the
>>> derbylang test suite. (I did not even see the failure in
>>> lang/floattypes.sql that Tomohito saw. It was probably fixed in Derby
>>> updates I picked up today).
>>>
>>> Jack Klebanoff
>>>
>>>
>>>
>>> -- 
>>> No virus found in this incoming message.
>>> Checked by AVG Anti-Virus.
>>> Version: 7.0.308 / Virus Database: 266.8.4 - Release Date: 2005/03/27
>>>
>>>
>>
>>
> 
> 
> 
> 
> -- 
> No virus found in this incoming message.
> Checked by AVG Anti-Virus.
> Version: 7.0.308 / Virus Database: 266.8.4 - Release Date: 2005/03/27
> 
>


-- 
No virus found in this outgoing message.
Checked by AVG Anti-Virus.
Version: 7.0.308 / Virus Database: 266.8.6 - Release Date: 2005/03/30


Mime
View raw message