db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Satheesh Bandaram <sathe...@Sourcery.Org>
Subject Re: About improvement of DERBY-134
Date Fri, 11 Feb 2005 19:10:45 GMT
<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
<html>
<head>
  <meta content="text/html;charset=ISO-2022-JP"
 http-equiv="Content-Type">
  <title></title>
</head>
<body bgcolor="#ffffff" text="#000000">
I think the patch is a good start. But more work needs to be done.
Based on a quick review, some of the items to be completed are: (there
may be more)<br>
<ul>
  <li>Grammar ambiguity. SortKey() has grammar ambiguity the way the
patch is written. Since orderby expression and orderby column can both
start with an identifier, this causes ambiguity. Need to rewrite or add
lookup to avoid this.</li>
  <li>Current patch doesn't seem to support all expressions, Ex: <b>select
i from t1 order by i/2</b>. So, needs more work.</li>
  <li>Add more test cases and test outputs to show changed behavior.
You could add test cases to orderby.sql test that is already part of
functionTests/tests/lang.</li>
</ul>
I do encourage you to continue work on this ...<br>
<br>
Satheesh<br>
<br>
TomohitoNakayama wrote:<br>
<blockquote cite="mid003101c50e9a$4e419340$2000a8c0@Arkat" type="cite">I
tried to solve DERBY-134.
  <br>
Patch is attached to this mail.
  <br>
  <br>
  <br>
/*
  <br>
  <br>
&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; Tomohito Nakayama
  <br>
&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; <a class="moz-txt-link-abbreviated"
href="mailto:tomoihto@rose.zero.ad.jp">tomoihto@rose.zero.ad.jp</a>
  <br>
&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; <a class="moz-txt-link-abbreviated"
href="mailto:tomonaka@basil.ocn.ne.jp">tomonaka@basil.ocn.ne.jp</a>
  <br>
  <br>
&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; Naka
  <br>
&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; <a class="moz-txt-link-freetext"
href="http://www5.ocn.ne.jp/~tomohito/TopPage.html">http://www5.ocn.ne.jp/~tomohito/TopPage.html</a>
  <br>
  <br>
*/
  <br>
----- Original Message ----- From: "TomohitoNakayama"
<a class="moz-txt-link-rfc2396E" href="mailto:tomonaka@basil.ocn.ne.jp">&lt;tomonaka@basil.ocn.ne.jp&gt;</a>
  <br>
To: "Derby Development" <a class="moz-txt-link-rfc2396E" href="mailto:derby-dev@db.apache.org">&lt;derby-dev@db.apache.org&gt;</a>
  <br>
Sent: Wednesday, February 09, 2005 5:33 PM
  <br>
Subject: Re: About improvement of DERBY-134
  <br>
  <br>
  <br>
  <blockquote type="cite">Woops.
    <br>
Mistaken.
    <br>
    <br>
    <blockquote type="cite">That's "DERBY-124 Sorted string columns are
sorted in a case sensitive way"
      <br>
    </blockquote>
    <br>
    <br>
That's "DERBY-134 Sorted string columns are sorted in a case sensitive
way"
    <br>
    <br>
/*
    <br>
    <br>
&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; Tomohito Nakayama
    <br>
&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; <a class="moz-txt-link-abbreviated"
href="mailto:tomoihto@rose.zero.ad.jp">tomoihto@rose.zero.ad.jp</a>
    <br>
&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; <a class="moz-txt-link-abbreviated"
href="mailto:tomonaka@basil.ocn.ne.jp">tomonaka@basil.ocn.ne.jp</a>
    <br>
    <br>
&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; Naka
    <br>
&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; <a class="moz-txt-link-freetext"
href="http://www5.ocn.ne.jp/~tomohito/TopPage.html">http://www5.ocn.ne.jp/~tomohito/TopPage.html</a>
    <br>
    <br>
*/
    <br>
----- Original Message ----- From: "TomohitoNakayama"
<a class="moz-txt-link-rfc2396E" href="mailto:tomonaka@basil.ocn.ne.jp">&lt;tomonaka@basil.ocn.ne.jp&gt;</a>
    <br>
To: <a class="moz-txt-link-rfc2396E" href="mailto:derby-dev@db.apache.org">&lt;derby-dev@db.apache.org&gt;</a>
    <br>
Sent: Wednesday, February 09, 2005 4:35 PM
    <br>
Subject: About improvement of DERBY-134
    <br>
    <br>
    <br>
    <blockquote type="cite">Hello.
      <br>
My name is Naka.
      <br>
I'm very newbie in derby community.
      <br>
      <br>
I'm now seeing report for derby in ASF Jira.
      <br>
And found a interesting issue.
      <br>
      <br>
That's "DERBY-124 Sorted string columns are sorted in a case sensitive
way"
      <br>
      <br>
This issue seems to mean that we can't use complex item in order
clause.
      <br>
#That title was difficult to understand a bit ....
      <br>
      <br>
Solving this isn't useful?
      <br>
Especially when we manipulate DBMS by hand.
      <br>
      <br>
What I think we need to do is as next:
      <br>
      <br>
1) Allow additiveExpression()&nbsp; in sortKey() in "sqlgrammer.jj". 2) Make
OrderByColumn class to support additiveExpression.
      <br>
      <br>
Best regards.
      <br>
      <br>
/*
      <br>
      <br>
&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; Tomohito Nakayama
      <br>
&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; <a class="moz-txt-link-abbreviated"
href="mailto:tomoihto@rose.zero.ad.jp">tomoihto@rose.zero.ad.jp</a>
      <br>
&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; <a class="moz-txt-link-abbreviated"
href="mailto:tomonaka@basil.ocn.ne.jp">tomonaka@basil.ocn.ne.jp</a>
      <br>
      <br>
&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; Naka
      <br>
&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; <a class="moz-txt-link-freetext"
href="http://www5.ocn.ne.jp/~tomohito/TopPage.html">http://www5.ocn.ne.jp/~tomohito/TopPage.html</a>
      <br>
      <br>
*/
      <br>
      <br>
      <br>
--&nbsp;<br>
No virus found in this outgoing message.
      <br>
Checked by AVG Anti-Virus.
      <br>
Version: 7.0.300 / Virus Database: 265.8.6 - Release Date: 2005/02/07
      <br>
      <br>
      <br>
      <br>
      <br>
--&nbsp;<br>
No virus found in this incoming message.
      <br>
Checked by AVG Anti-Virus.
      <br>
Version: 7.0.300 / Virus Database: 265.8.6 - Release Date: 2005/02/07
      <br>
      <br>
      <br>
    </blockquote>
    <br>
    <br>
--&nbsp;<br>
No virus found in this outgoing message.
    <br>
Checked by AVG Anti-Virus.
    <br>
Version: 7.0.300 / Virus Database: 265.8.6 - Release Date: 2005/02/07
    <br>
    <br>
    <br>
    <br>
    <br>
--&nbsp;<br>
No virus found in this incoming message.
    <br>
Checked by AVG Anti-Virus.
    <br>
Version: 7.0.300 / Virus Database: 265.8.6 - Release Date: 2005/02/07
    <br>
    <br>
  </blockquote>
  <pre wrap="">
<hr size="4" width="90%">
No virus found in this outgoing message.
Checked by AVG Anti-Virus.
Version: 7.0.300 / Virus Database: 265.8.6 - Release Date: 2005/02/07
  </pre>
</blockquote>
</body>
</html>

Mime
View raw message