db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Daniel John Debrunner <...@debrunners.com>
Subject Re: [PATCH] Change all Identifier Limitations to 128
Date Thu, 03 Feb 2005 18:31:48 GMT
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Daniel John Debrunner wrote:

> Philipp Hug wrote:
>
>
>>this patch changes maximum length of column names, index/contraint
>>names, cursor names and schema names to 128 and keeps MaxUserNameLength
>>at 30.
>>it also fixes the metadata to return correct values
>
>
> A couple of the tests fail with this patch, looks like they are just a
> result of the limit changing, rather than anything wrong.


This patch hasn't been applied yet. I think it's been held up because
as-is it causes the functional tests to "fail".

I think maybe the committers need to add some information on the site
about how to commit patches and items the contributor can do to increase
the chance and pace of acceptance.

With cases like this where the test "failures" are due to correct change
of behaviour, who should be updating the test output? Speaking for
myself as a committer, I don't have time to clean up test failures for
patches. Maybe once in a while, but not on a regular basis.

Dan.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.5 (MingW32)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFCAm4UIv0S4qsbfuQRAhv4AJoDgYdhxUmvRNuNViyQ/CyTqYueeACg5I41
fOqZMFGP70Ti3HzLwnYSqjM=
=NyWl
-----END PGP SIGNATURE-----


Mime
View raw message