db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Shreyas Kaushik <Shreyas.Kaus...@Sun.COM>
Subject Re: [jira] Commented: (DERBY-18) Exposed name matching has bugs when the column name is qualified with a schema name.
Date Thu, 03 Feb 2005 03:45:06 GMT
Dan,

  Attached is the new patch and answesr are inline.

~ Shreyas.

Daniel John Debrunner wrote:

>-----BEGIN PGP SIGNED MESSAGE-----
>Hash: SHA1
>
>Shreyas Kaushik wrote:
>  
>
>>Any updates on this??
>>
>>thanks
>>Shreyas
>>
>>Shreyas Kaushik wrote:
>>
>>    
>>
>>>I am attaching the latest diffs for Derby-18.
>>>
>>>This tries to address Dan's comments in his previous mails.
>>>Let me know the whether the extra checks that I have added, in
>>>comparision to the diffs I sent out earlier
>>>are correct/sufficient.
>>>      
>>>
>
>I've been busy doing other stuff, from a quick look at this I'm was more
>thinking that the schema name in TableName would be filled in at a
>single point, rather than on each use of it. This latter approach tends
>to increase code size and be more buggy as there is potential for some
>uses to be missed. I would expect that this could be encapsulated in
>FromTable or FromBaseTable, maybe additional checks in the getTableName
>method?
>  
>
Ok I guess you are right, a good appraoch at doing things more 
concisely. I have made the changes
in FromBaseTableName and CurrentOfNode.

>Dan.
>
>-----BEGIN PGP SIGNATURE-----
>Version: GnuPG v1.2.5 (MingW32)
>Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
>
>iD8DBQFCAB/dIv0S4qsbfuQRAjRlAJ9ujj9gLG7mnuDmi2UMbVIHV/aDpACePKas
>s8t0EM82u63D1UST+24LQSk=
>=+rpI
>-----END PGP SIGNATURE-----
>
>  
>

Mime
View raw message