db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Kathey Marsden <kmars...@Sourcery.Org>
Subject Re: "Cosmetic" changes
Date Fri, 21 Jan 2005 13:50:58 GMT
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Jeremy Boynes wrote:
[snip]
> I would like to propose a gradual clean-up of these issues - a kind of
> "cosmetic" patch process which does not change any functionality but
> just tidies up code. One rule would be that these type of changes would
> not be mixed in with real patches for bug fixes or new features (which
> would fit with removing them from the Derby-13 patch).

>
> How do people feel about this?
> --

I think a clean-up effort would be great. I especially think it is a
wonderful way for folks to get their feet wet with Derby.  It is great
to go through the process of making changes, running tests and
submitting a patch just to get the process under one's belt.

I think, however, it is ok to allow some cleanup to go along with
patches.  Sometimes you are working in an area and see something and it
is easy to fix it while you are there.  Of course there is a balance.
If the cleanup makes the diff unclear, then it should wait.

Kathey




> Jeremy
>
>

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.5 (MingW32)
Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org

iD8DBQFB8QjCG0h36bFmkocRAkcMAJ0Y3/ZcPszSwS5HwFj4hFelpN1l9ACfagzv
B2hRk+eG21igc4lCrnzggYs=
=KtzQ
-----END PGP SIGNATURE-----

Mime
View raw message