db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Daniel John Debrunner <...@debrunners.com>
Subject Re: (DERBY-13) Quoted names with embedded period mishandled in from
Date Thu, 20 Jan 2005 23:49:48 GMT
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Shreyas & I worked through his Derby-13 patch off this list to come to a
conclusion. The summary of that discussion is:


- - I had misunderstood that FromTable.getTableName() already handled the
correlation name, return a TableName of <null,correlationName> in that
case. I had thought that it returned the underlying actual table name.
Once Shreyas pointed that out I started to understand his fix. I do
think that beyond this patch there is some cleanup in this area as if
getTableName() encapsulates exposed name handling, then there should be
no need for any public getExposedName methods.

- - I then questioned when FromTable.getTableName() could return null as
Shreyas was checking for it in the changes in FromList. He re-ran the
tests without the check and hit an exception in lojreorder.sql. Looking
at that I pointed out that the correct check would be if the FromTable
is an instanceof TableOperatorNode, which would map the existing check.

- - and the final change was to not re-build TableName objects in the
FromList duplicate exposed name checking, but use the objects directly
from FromList.getTableName() as TableName objects are re-useable

- - Shreyas also provided some test cases which I added to the existing
select.sql test.

- - I also removed the modifications to TableName from the patch as they
were only cosmetic.


I will commit this tomorrow if there are no other review comments on the
patch.

Dan.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.5 (MingW32)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFB8EOcIv0S4qsbfuQRAiYFAJ9ytZTHpNjmJp3qLfSKa0oGh6iWVwCfa5td
fW5smzisdhTyfo6Orl1fbS0=
=h8qk
-----END PGP SIGNATURE-----

Mime
View raw message