db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Army <a...@golux.com>
Subject Re: [PATCH] Multiple EXCSAT fix
Date Thu, 20 Jan 2005 19:35:53 GMT
Kathey Marsden wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> Hello All,
> 
> The attached patch is to address an issue  with the Network Server
> regarding the handling of the EXCSAT codepoint.

[ snip ]

> I will check this in noon tomorrow if there are no objections.

This looks good to me.  I only have one minor comment:

> @@ -801,8 +804,20 @@
>  					}
>  					break;
>  				case CodePoint.EXCSAT:
> -					parseDRDAConnection();
> +					parseEXCSAT();
> +					writeEXCSATRD();
> +					finalizeChain();
> +					break;

I don't think we need to add the "finalizeChain()" call here.  The "break" will cause the
thread to exit the switch 
statement, and immediately after the switch is an existing call to "finalizeChain" that does
the same thing.  If we 
leave this line in, we get two calls to "finalizeChain" in a row--and while that doesn't appear
to be a problem (tests 
still pass), it might be good to remove the unneeded call anyway.

Other than that, since you've run the derbynetmats suite, +1 from me.

Army

Mime
View raw message