db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From myrnap <my...@Golux.Com>
Subject Re: [PATCH] creating Derby plug-in for Eclipse
Date Thu, 06 Jan 2005 03:20:09 GMT
Andrew McIntyre wrote:

>
> On Dec 29, 2004, at 4:01 PM, Jean T. Anderson wrote:
>
>> Rajesh Kartha wrote:
>>
>>> Also was thinking, since Derby has a branch for 10.0, can this patch
>>
>> be added to that, so there can be  a corresponding Eclipse plug-in 
>> release
>>
>>> for the officially released Derby 10.0.2.1 currently available at:
>>>
>>> http://incubator.apache.org/derby/derby_downloads.html
>>
>
> Hi Rajesh,
>
> This patch looks good to me. If there are no further comments on the 
> patch by Friday, I will assume lazy approval for this and commit the 
> patch to both trunk and the 10.0 branch as well, since this only 
> affects build files.
>
> Jean also mentioned elsewhere that it would be good to get a snapshot 
> of the plugin up on the website. I will provide a snapshot of the 
> plugin to her once the patch has been committed.
>
> andrew
>
I had one comment - but I keep hesitating about this: if you've done a 
all target, followed immediately (without clobber) by the plugin target, 
you also get derbyTesting.jar. I'm not sure this is desired...If not, 
maybe the exclude should also have derbyTesting.jar, not just the 
derby*locale*jars...
On the other hand, it's up to the person building the plugin - if they 
don't want the testing stuff in the plugin, don't build that 
beforehand...maybe it's ok?

Myrna

Mime
View raw message