db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Daniel John Debrunner <...@debrunners.com>
Subject Re: (DERBY-13) Quoted names with embedded period mishandled in from
Date Tue, 04 Jan 2005 20:06:06 GMT
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Comments on the patch 'Derby-13.diff' attached to the Jira bug Derby-13

I think we are making progress, but some comments:

- - How do you (or someone else) know the bug is fixed if there are no
test cases added for it?

- - I would expect a more complete change to use TableName, rather than
String for exposed name. That is, an exposed name is always handled as a
TableName and not a string. Your approach is to keep the exposed name as
a String and convert it to a TableName as required. I think it will be a
lot cleaner if it is always a TableName and never a String. Ie.
getExposedName() returns a TableName.
I think your code then leads to a problem, where the schema name for an
exposed name is incorrect, as you take the schema name of the table, not
the current schema. Though I could be wrong on this. Namely in this
situation, what is the actual value for the exposed (correlation) name?

set current schema A;

select * from B.T1 AS C


What is the correlation name

  C (no associated schema?)
  A.C
  B.C

??

I briefly looked through the SQL spec a while ago on this issue and
couldn't find the answer.

Dan.


-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.5 (MingW32)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFB2vcuIv0S4qsbfuQRAh89AKC833wihGxL+9Dl0Ez0WRPgEIwobgCgiUkk
e3gpw1RQQpembWsgOGy6sfA=
=OEii
-----END PGP SIGNATURE-----


Mime
View raw message