db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Daniel John Debrunner <...@debrunners.com>
Subject Re: [VOTE][PATCH]delete from the resultset using JDBC 2.0 Updatable Resultset APIs
Date Tue, 04 Jan 2005 19:24:48 GMT
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

> I would like to resubmit the patch for Updatable ResultSet JDBC 2.0
> - delete functionality only. This patch has changes as discussed in thread
>
http://nagoya.apache.org/eyebrowse/ReadMsg?listName=derby-dev@db.apache.org&msgNo=1356
>
> My vote : +1. Please send in your votes.


Some comments:

EmbedDatabaseMetaData
- ---------------------

Can you explain changing the other updates are visible methods to
false, maybe by comments in the code.

EmbedResultSet20
- ----------------

getConcurrency() method
    I think this implementation is incorrect. A ResultSet that is
created read-only, but uses a FOR UPDATE clause will return it is
updateable. This is currently used for positioned updates.
I think also a ResultSet that is created as updateable will change to be
read only if the underlying language result set is not updateable. In
this case I think a warning should be generated as well, which I don't
think will happen with your code.

 deleteRow() method
    Why is the check on theResults.isClosed() needed?

    When pushing the statement context, shouldn't you use the text of
the delete SQL statement, and not the sql text of the current result
set? Also you are passing in the parameters of the query which are not
required and not relevant to the positioned delete.

    A comment for the line 'rowData = null' would be very useful

SQLState.java
- --------------
    Typo in constant, need S in DISALLOWED
    UPDATABLE_RESULTSET_API_DIALLOWED

Dan.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.5 (MingW32)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFB2u2AIv0S4qsbfuQRAu6nAKC18s2fPxUDJEfif8Htktrx7QoRKwCfWzSu
ABOTO+fQyqEwHz5V/UBRzL8=
=IAO9
-----END PGP SIGNATURE-----


Mime
View raw message