db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Daniel John Debrunner <...@debrunners.com>
Subject Re: [jira] Commented: (DERBY-13) Quoted names with embedded period mishandled in from list
Date Mon, 03 Jan 2005 17:29:59 GMT
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Shreyas Kaushik (JIRA) wrote:
>      [
http://issues.apache.org/jira/browse/DERBY-13?page=comments#action_57179 ]
>
> Shreyas Kaushik commented on DERBY-13:
> --------------------------------------
>
> I am proposing a fix for this issue. I am attaching the diffs of all
the files that need to have changes.
>
> As per the discussions we have had on this issue the problem was with
comparing exposed names. I have changed the comparision of all exposed
names to the TableName objects.
>
> As Sateesh had suggested in one of his earlier mails on this issue,
>
> public ResultColumnList getResultColumnsForList(String
allTableName,ResultColumnList inputRcl,Name tableName)
>
>  method in the FromTable.java the "allTableName" needs to be a
TableName object instead of a String object. I have made those changes
as well for the comparision to happen between TableName objects.
>
>   For the above change to happen we need to get a handle to the
TableName object that is stored in the
java/engine/org/apache/derby/impl/sql/compile/AllResultColumn. As of now
it does not have a method to actually get a handle to the TableName
object stored in this. So I added a new method that returns a handle to
the TableName object stored internally.
>
> I also ran the tests of derbylang and am attaching the diffs of them
as well. Some of the tests fail there and I don't know the exact reason
for the failures.( I think they are not failures )

I actually think you are seeing unrelated failures. It seems that if
Derby is built and tested on linix or unix then about six tests fail, it
looks like a difference in the number of characters in a long line. I'm
not sure if it's the build process, ij or the test diff program that has
the problem. If you build on Windows and test on linux or unix the all
the tests pass.

Dan.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.5 (MingW32)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFB2YEXIv0S4qsbfuQRAqK2AJ9j0+VWZyBTvDG2I0CuPtND6mnWGgCfXpUs
Nd4OzchMh0E550yTvTczFvM=
=iQmd
-----END PGP SIGNATURE-----


Mime
View raw message