db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Daniel John Debrunner <...@debrunners.com>
Subject Re: [PATCH] Intersect and Except
Date Sat, 18 Dec 2004 03:38:14 GMT
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Jack Klebanoff wrote:

> I have attached an update to my previous INTERSECT/EXCEPT patch. It
> addresses a number of concerns brought up in this thread.

Minor (repeated comment) in SetOpResultSet.java

+    private int compare( DataValueDescriptor[] leftCols,
DataValueDescriptor[] rightCols)
+        throws StandardException
+    {
+        for( int i = 0; ; i++)
+        {
+            if( i >= intermediateOrderByColumns.length)
+                return 0;



This style of loop is still really awkward to read and understand.

Typically it's written

for (int i = 0 ; i < intermediateOrderByColumns.length; i++)
{
 ...
}
return 0


Dan.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.5 (MingW32)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFBw6YmIv0S4qsbfuQRAkjLAJ4rAe9ktat6HQgpAdd/OWxjTQmx5QCg4E/n
dDh6TshqnVhvPB0HqqxR8AY=
=x4/0
-----END PGP SIGNATURE-----


Mime
View raw message