db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Daniel John Debrunner <...@debrunners.com>
Subject Re: [PATCH] Change all Identifier Limitations to 128
Date Fri, 17 Dec 2004 19:32:46 GMT
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Philipp Hug wrote:

> this patch changes maximum length of column names, index/contraint
> names, cursor names and schema names to 128 and keeps MaxUserNameLength
> at 30.
> it also fixes the metadata to return correct values

A couple of the tests fail with this patch, looks like they are just a
result of the limit changing, rather than anything wrong.

Dan.

********* Diff file derbyall/derbylang/metadata.diff
*** Start: metadata jdk1.4.2 derbyall:derbylang 2004-12-17 10:12:59 ***
15 del
< maxColumnNameLength(): 30
15a15
> maxColumnNameLength(): 128
134 del
< getMaxCursorNameLength(): 18
134a134
> getMaxCursorNameLength(): 128
136 del
< getMaxSchemaNameLength(): 30
136a136
> getMaxSchemaNameLength(): 128
Test Failed.
*** End:   metadata jdk1.4.2 derbyall:derbylang 2004-12-17 10:13:29 ***
********* Diff file derbyall/derbylang/currentSchema.diff
*** Start: currentSchema jdk1.4.2 derbyall:derbylang 2004-12-17 10:24:32 ***
310,320d309
< ERROR 42622: The name 'T234567890123456789012345678901' is too long.
The maximum length is '30'.
< ij> set schema t234567890123456789012345678901;
< ERROR 42622: The name 'T234567890123456789012345678901' is too long.
The maximum length is '30'.
< ij> set schema 'T234567890123456789012345678901';
< ERROR 42622: The name 'T234567890123456789012345678901' is too long.
The maximum length is '30'.
< ij> execute p1 using 'values(''T234567890123456789012345678901'')';
< ERROR 42Y07: Schema 'T234567890123456789012345678901' does not exist
< ij> rollback;
< ij> autocommit on;
< ij> -- clean up
< drop schema judy restrict;
321a311,321
> ij> set schema t234567890123456789012345678901;
> 0 rows inserted/updated/deleted
> ij> set schema 'T234567890123456789012345678901';
> 0 rows inserted/updated/deleted
> ij> execute p1 using 'values(''T234567890123456789012345678901'')';
> 0 rows inserted/updated/deleted
> ij> rollback;
> ij> autocommit on;
> ij> -- clean up
> drop schema judy restrict;
> 0 rows inserted/updated/deleted
323 del
< ERROR 42622: The name 'T234567890123456789012345678901' is too long.
The maximum length is '30'.
323a323
> ERROR 42Y07: Schema 'T234567890123456789012345678901' does not exist
Test Failed.
*** End:   currentSchema jdk1.4.2 derbyall:derbylang 2004-12-17 10:24:45 ***
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.5 (MingW32)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFBwzReIv0S4qsbfuQRAvXQAJoDiAjCSAVlmdvbY3NSORPxy+W2FQCfS8z0
P6S+lQLNPu+S+l85pss2vrQ=
=Hok8
-----END PGP SIGNATURE-----


Mime
View raw message