db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Daniel John Debrunner <...@debrunners.com>
Subject Re: [PATCH] Change all Identifier Limitations to 128 - v2
Date Thu, 16 Dec 2004 18:02:21 GMT
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Philipp Hug wrote:

> you're right. I did also find another place where a DB2 specific
> limitation was specified and moved it into DerbyLimits.java
> dblook.DB2_MAX_NUMBER_OF_TABLES --> DerbyLimits.DERBY_MAX_NUMBER_OF_TABLES
>
> btw: there's a problem with "ant clean":
> it doesn't remove the autogenerated java files like SQLParser.java...
> that's why it still compiled for me, even there were still references to
> DB2Limit :-(
>
> I did update to the latest svn trunk version and created the diff
> against it.

- -1

for reasons given in earlier e-mail, exemplified in the example below
like this, where the comment as to why the limit exists has been removed.

I think the first patch that just changed the identifers to 128
characters is good, and maybe could be improved with moving the 128
identifier length constant out of Db2Limit.

Dan.
PS. ant clobber removes all the generated files, and performs the clean
action.

 public class dblook {

- -	// DB2 enforces a maximum of 30 tables to be specified as part of
- -	// the table list.
- -	public static final int DB2_MAX_NUMBER_OF_TABLES = 30;
- -
- -	private Connection conn;
+    private Connection conn;
 	private static PreparedStatement getColNameFromNumberQuery;

 	// Mappings from id to name for schemas and tables (for ease
@@ -430,7 +427,7 @@
 		while (argIndex < args.length) {

 			if (((args[argIndex].length() > 0) && (args[argIndex].charAt(0) ==
'-')) ||
- -				(++count > DB2_MAX_NUMBER_OF_TABLES))
+				(++count > DerbyLimit.DERBY_MAX_NUMBER_OF_TABLES))



Dan.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.5 (MingW32)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFBwc2tIv0S4qsbfuQRAl2nAJ9gBAulxg6OLxODJCTt0GRzLmGLYQCgqITU
EwRwQGvQdUYXFM768/1SoTA=
=LZcP
-----END PGP SIGNATURE-----


Mime
View raw message