db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Daniel John Debrunner <...@debrunners.com>
Subject Re: [PATCH] Change all Identifier Limitations to 128
Date Thu, 16 Dec 2004 17:13:52 GMT
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Lance J. Andersen wrote:
> +1 IMHO.
>
> Regards
> Lance
>
> Philipp Hug wrote:
>
>> Ok, I could create a new patch that also renames DB2_ into DERBY_ and
>> renames DB2Limit into DerbyLimit.
>> How does that sound?
>>
>> philipp
>>
>> Lance J. Andersen wrote:
>>
>>> If  the changes being made differ from the DB2 limits, and it does
>>> make sense to change this now that Derby is part of apache, I would
>>> pull the constants out of DB2Limit.java as this seems confusing from
>>> the outside looking in.

I would actually advise against that, or at least a more controlled
approach than just changing DB2 to Derby.

The fact that they are marked as DB2 limits indicates why they were put
in place, this may be useful information in the future. It identifies a
limit that most likely is soft, rather than inherent in the Derby
architecture.

So I would say for the 128 identifier limit, it should be moved out of
DB2Limit, as 128 is inherent to Derby, the system tables are all set at
128 characters for identifiers. Or maybe it is inherent to the SQL
standard and thus the limit is described as a SQLStandard limit?

But the other limits, I would leave as DB2Limit constants until someone
changes them.

Dan.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.5 (MingW32)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFBwcJQIv0S4qsbfuQRAvkoAKCSP1Zu21NsfVar7fi9dsQlobJ2YgCeK+Bk
eZe1KXqsQtxHYy9OXlSFECQ=
=hZUv
-----END PGP SIGNATURE-----


Mime
View raw message