db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Daniel John Debrunner <...@debrunners.com>
Subject Re: [PATCH] Intersect and Except
Date Fri, 10 Dec 2004 22:34:02 GMT
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

For java source files that are completely new code (e.g.
IntersectOrExceptNode.java) the copyright creation date should be 2004,
not 1997.

Can you explain why we need the classes ExceptNode.java and
IntersectNode.java? They seem to provide little value and the code could
be folded into the parent class easily. I'm always concerned about the
footprint of Derby and each class file has overhead.

Does the javadoc comment for SetOpProjectRestrictResultSet match what it
is doing? Is a UNION ALL being used?

+/**
+ * Takes the result set produced by an ordered UNION ALL of two tagged
result sets and produces
+ * the INTERSECT or EXCEPT of the two input result sets. This also
projects out the tag, the last column
+ * of the input rows.
+ */

In SetOpProjectRestrictResultSet.compare() this code confused me for a
while. It would be better written as a standard loop with the condition
i < leftCols.length in the for operator, and then return 0 after the
loop. Similar to how the next method isDuplicate() is coded.

+        for( int i = 0; ; i++)
+        {
+            if( i >= leftCols.length)
+                return 0;




Dan.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.5 (MingW32)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFBuiRaIv0S4qsbfuQRAhEcAKCe6OmLmhjS14A8ymzUuTXehdgD3wCg3w+I
Ne3biR85T9EwMptYWESfUlI=
=ZXbp
-----END PGP SIGNATURE-----


Mime
View raw message